Remove unused variable from block module

1. +++ b/core/modules/block/block.post_update.php
   @@ -86,7 +86,7 @@ function block_post_update_fix_negate_in_conditions() {
   +    foreach ($block->getVisibilityConditions() as  $condition) {
   

   Extra space after "as"

2. +++ b/core/modules/block/src/Plugin/migrate/process/BlockPluginId.php
   @@ -76,7 +76,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
   +          list($type) = explode('-', $delta);
   

   I realise this is unused but the code is easier to read with it in place.

+++ b/core/modules/block/block.post_update.php
@@ -86,7 +86,7 @@ function block_post_update_fix_negate_in_conditions() {
-    foreach ($block->getVisibilityConditions() as $condition_id => $condition) {
+    foreach ($block->getVisibilityConditions() as $condition) {

Looks good here since the array key $condition_id not being used

+++ b/core/modules/block/src/Plugin/migrate/process/BlockPluginId.php
@@ -76,7 +76,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
-          list($type, $id) = explode('-', $delta);
+          list($type) = explode('-', $delta);
           if ($type == 'feed') {

Looks good here since $id not being used

+++ b/core/modules/block/tests/src/Functional/BlockTest.php
+++ b/core/modules/block/tests/src/Functional/BlockTest.php
@@ -417,7 +417,7 @@ public function testBlockCacheTags() {

@@ -417,7 +417,7 @@ public function testBlockCacheTags() {
     // Place the "Powered by Drupal" block another time; verify a cache miss.
...
+    $this->drupalPlaceBlock('system_powered_by_block', ['id' => 'powered-2']);

Looks good here since $block2 never being used

+++ b/core/modules/block/block.post_update.php
@@ -86,7 +86,7 @@ function block_post_update_fix_negate_in_conditions() {
       $configuration = $condition->getConfiguration();

Per other issues specifying the key helps with readability and people often do this intentionally even if the key isn't actually used. If we're going to make this a coding-style rule we should open a proper coding standards issue to do so.

Rerolled patch to keep the key in foreach.

+++ b/core/modules/block/src/Plugin/migrate/process/BlockPluginId.php
@@ -76,7 +76,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
-          list($type, $id) = explode('-', $delta);
+          list($type) = explode('-', $delta);

$id adds context here, I think it is more readable with it in place.

edit: I already said that in #4 :)

@longwave updated the Patch to keep $id.

Thanks, the one remaining one is fine.

Committed 228df49 and pushed to 9.0.x. Thanks!