CommentFileSizeAuthor
#2 3105976-2.patch771 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3105976-2.patch771 bytes

Kindly review a new patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
snehalgaikwad’s picture

snehalgaikwad commented
Status: Needs review » Reviewed & tested by the community

I've tried this patch, working fine.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs change record

This should be fine to commit in a minor release, since no-one should be calling this indirectly. However I think it could use a just-in-case change record documenting that we now require the type-hint.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Version: 9.0.x-dev » 9.1.x-dev
Issue tags: -Needs change record

I added a change record. I've never added one before so update it if it needs adjusting.

https://www.drupal.org/node/3158723

Patch still applies to 9.1.x but I have kicked off tests since they were run on 9.0.x.

If the tests come back green, this looks RTBC to me.

hardik_patel_12’s picture

hardik_patel_12 commented

I have retested the patch and it's again green. So it's looks good to move.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks but I'm unclear why you ran the tests a second time.

Anyway, all green so RTBC. :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed af4c993 and pushed to 9.1.x. Thanks!

  • alexpott committed af4c993 on 9.1.x 
    Issue #3105976 by Hardik_Patel_12, Kristen Pol, catch: Type hint "\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.