I get a few warnings after installing the theme with Yarn in Ubuntu 18.04:

Install Yarn in Ubuntu 18.04:

$ curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
$ echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
$ sudo apt update && sudo apt install yarn
$ yarn -v
1.21.1

From https://yarnpkg.com/en/docs/install#debian-stable

Get Olivero theme and enter folder:

$ git clone --branch 8.x-1.x-dev https://git.drupalcode.org/project/olivero.git
$ cd olivero

Install dependencies with Yarn:

$ yarn install
yarn install v1.21.1
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.9: The platform "linux" is incompatible with this module.
info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " > eslint-plugin-prettier@3.1.1" has incorrect peer dependency "eslint@>= 5.0.0".
warning "stylelint > postcss-html@0.23.7" has incorrect peer dependency "postcss-syntax@^0.10.0".
warning "stylelint > postcss-markdown@0.23.7" has incorrect peer dependency "postcss-syntax@^0.10.0".
warning " > stylelint-order@3.1.1" has incorrect peer dependency "stylelint@>=10.0.1".
[4/4] Building fresh packages...
Done in 6.25s.

It works fine, and after disabling Drupal caching, running yarn run watch:css changes to the template files result in new CSS-files automatically. But as you can see I get some warnings like info fsevents@1.2.9: The platform "linux" is incompatible ... as well as stylelint and eslint, perhaps because I am using Ubuntu? Current set up:

  • Ubuntu 18.04
  • Node.js v13.6.0
  • npm 6.13.4
  • Yarn 1.21.1
CommentFileSizeAuthor
#13 3105437-13-yarn-warnings-full.patch338.55 KBmherchel
#13 3105437-13-yarn-warnings-no-dist.patch273.61 KBmherchel
#10 3105437-10.patch535.99 KBkostyashupenko

Comments

ressa created an issue. See original summary.

ressa’s picture

ressa
he/him
commented

EDIT: I updated the issue to revolve around yarn in stead of npm, after the Olivero project was moved from Github to drupal.org. I found the issue fsevents@1.1.3: The platform "linux" is incompatible with this module which seems relevant

Original npm issue comment: I found the npm issue Log failed optional platform dependencies as info, hopefully this will get fixed soon.

ressa’s picture

ressa
he/him
commented
Issue summary: View changes

Updated from npm to yarn.

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
ressa’s picture

ressa
he/him
commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Closed (outdated)
ressa’s picture

ressa
he/him
commented
Status: Closed (outdated) » Active

I still get these warnings ...

$ yarn install
yarn install v1.22.4
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.9: The platform "linux" is incompatible with this module.
info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " > eslint-plugin-prettier@3.1.1" has incorrect peer dependency "eslint@>= 5.0.0".
warning "stylelint > postcss-html@0.23.7" has incorrect peer dependency "postcss-syntax@^0.10.0".
warning "stylelint > postcss-markdown@0.23.7" has incorrect peer dependency "postcss-syntax@^0.10.0".
warning " > stylelint-order@3.1.1" has incorrect peer dependency "stylelint@>=10.0.1".
[4/4] Building fresh packages...

Done in 2.79s.
  • Ubuntu 18.04
  • Node.js v13.12.0
  • Yarn 1.22.4
  • npm 6.14.4
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: Warnings during theme installation » Warnings during when running yarn install
ressa’s picture

ressa
he/him
commented
Title: Warnings during when running yarn install » Warnings when running yarn install
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
StatusFileSize
new 3105437-10.patch535.99 KB

1. Some packages were updated based on d9 core https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/package.json
2. Removed package-lock.json
3. Executed yarn build:css && yarn build:js commands to recompile styles/scripts based on new packages

Here is a list of updated files (updates at compiled css are related to autoprefixer around background: linear-gradient):

modified:   css/dist/components/breadcrumb.css
modified:   css/dist/components/embedded-media.css
modified:   css/dist/components/field-image.css
modified:   css/dist/components/footer.css
modified:   css/dist/components/form-select.css
modified:   css/dist/components/form-text.css
modified:   css/dist/components/header-search-narrow.css
modified:   css/dist/components/header-search-wide.css
modified:   css/dist/components/header.css
modified:   css/dist/components/table.css
modified:   css/dist/components/text-content.css
modified:   css/src/components/fieldset.css
deleted:    package-lock.json
modified:   package.json
modified:   yarn.lock

On my side no warnings/errors anymore during yarn install

ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Thanks @kostyashupenko, it's much better! I still get a single warning about fsevents:

$ yarn install
yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.12: The platform "linux" is incompatible with this module.
info "fsevents@1.2.12" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 7.76s.
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review

@ressa I guess during development it's ok to have this warning about fsevents, since fsevents is a dependency of https://www.npmjs.com/package/chokidar , and chokidar is a dependency of https://www.npmjs.com/package/postcss-cli.
We use postcss-cli package in our scripts like here https://git.drupalcode.org/project/olivero/-/blob/8.x-1.x-dev/package.js...

Drupal core is not using that package and it has own scripts to build postcss https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/scripts/css/...

So for now it's ok like this, @mherchel what do you think?

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3105437-13-yarn-warnings-no-dist.patch273.61 KB
new 3105437-13-yarn-warnings-full.patch338.55 KB

Re-rolling and committing. I'm attaching a patch without the dist files, and one with the dist files.

Thanks @kostyashupenko!

Note the only warning that I got (on a macbook) is

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Fixed

I'm going to commit this. If there's still issues, please open up a followup. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.