Adapt changes from media_library and theme system to the quick-edit dialog

So, the seven library makes the image move to the left in a grey backgrounded column.

I also use seven, but claro will replace seven soon :D

Do we really want to force the seven design?
I would prefer to remove the seven libraries everywhere, and maybe only add them if seven is the active theme using

\Drupal::service('theme.manager')->getActiveTheme()->getName() == 'seven'

I think claro will, like seven, support the media library. Thus, we need to make sure the "original" from hooks are invoked.

So, seven hooks in like this:

/**
 * Implements hook_form_BASE_FORM_ID_alter() for \Drupal\media\MediaForm.
 */
function seven_form_media_form_alter(&$form, FormStateInterface $form_state) {
  // Only attach CSS from core if this form comes from Media core, and not from
  // the contrib Media Entity 1.x branch.
  if (\Drupal::moduleHandler()->moduleExists('media') && $form_state->getFormObject() instanceof MediaForm) {
    // @todo Revisit after https://www.drupal.org/node/2892304 is in. It
    // introduces a footer region to these forms which will allow for us to
    // display a top border over the published checkbox by defining a
    // media-edit-form.html.twig template the same way node does.
    $form['#attached']['library'][] = 'seven/media-form';
  }
}

Seems a bigger issue with visual impact in 8.2.1/2 .. I think we mess with the seven-theme-image-widget .. we need to include different libraries, and use new CSS classes and then decide what we want to include use finally ..

This patch unifies now the AddMediaForm and MediaEditForm. Also a new help text was added on the main modules setting page via hook_form_alter.

A new definable form display mode should be probably discussed and handled in another issue.

AddMedia and Editform looks now nice, on 8.7.x 8.8.1 and 8.8.2, in seven, claro, bartik and umami themes and gets now a custom library injected.

Somehow wrong CSS sneaked in the last patch ..

Here an improved patch for the AddMediaForm, the last patches did not really make it better ..

Thanks for your review.

This issue here has nothing to do with the remove link, except it's position (which is set by using display:flex and we do not need to make any adaptions for it).

I removed the preview in the AddForm because (fe. in claro), you can exchange the source fields data, and for images the preview was not updated and I did not want to implement that ...

I like your design proposal. They do not really differ from the current AddForm in the patch, or I don't see the difference?

• AddForm is still depending on the form display configuration. I introduced the source media field ("image widget") to the form, which should be exclude-able via the form display.
• The EditForm shall be as similar as possible to the AddForm (at least the php class). Optically I like the preview image, and yes, also this form shall respect the form display. I renamed this to quick-edit to reflect our intention for it.
• I want to keep custom code (php or css) and configuration as tiny as possible and reuse as much core as possilbe.

So, what exactly do you want to roll back now? We can also split and postpone this issue, as I started broaden it ...
To fix the initial issue of the missing styles in the EditForm we just need to add the libraries consequently.

So, here a patch actually also adding the library for claro. This just came clear to me today ..

Regarding c64b32f: I decided to be able to work with the source field and this new method hideExtraSourceFieldComponents should be respected in the AddMediaForm and inherited to the others. This is not yet in and could be done in #3101860: Cleanup :D [unused and obsolete] code -!-. This issue here for me is a first step in that direction (reworking all the Forms according to media_library's changes) of unifying the MediaEdit and AddMedia form, make it work with all versions of Drupal.

Thanks a lot for your feedback. I got here somehow lost in a form detection pattern.

I took now your approach for hiding the source field (like media_library), and plugged in my optical changes (more decent), and claro support (flex is not properly defined, so the preview image is really small and the delete button can hang over an input element- but I leave that up to claro).
The interdiff is not complete ...

I

• added a CSS file
• did cleanup of unused and duplicated code, made the media edit form extending the add form
• Override $_form_->getMediaType($form_state) in media edit form consequently

So, this is back to you ;)

Decided to already hide the source field in the add form.

Hmm strange - for me it worked all ... Did you test in a special setup?

Hiding the source field is really something I would like to bring in ..

I never tested with the combined upload, your not using that?
I will also try a fresh install and give you feedback here.

Totally my bad, Sorry!

Your last patch with "enabling" the source field again is the way it needs to be!

I think we got it here :D

Ups - the MediaEditForm was still not working, as you pointed out .. So here the fix.

And - thx for your patience :D