Warning: implode(): Invalid arguments passed in Drupal\config_export_ignore\Form\SettingsForm->buildForm() (line 38 of modules/contrib/config_export_ignore/src/Form/SettingsForm.php).

CommentFileSizeAuthor
#2 3104691-fix-php-warning-on-install-2.patch1.38 KBdaniel korte

Comments

Daniel Korte created an issue. See original summary.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Title: Initial install comes with a PHP warning since there are on config names to ignore » Initial install has a PHP warning since there are no config names to ignore yet
Assigned: daniel korte » Unassigned
Status: Active » Needs review
StatusFileSize
new 3104691-fix-php-warning-on-install-2.patch1.38 KB
daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Related issues: +#3049601: Doesn't seem to work

mohit_aghera’s picture

mohit_aghera commented
Status: Needs review » Fixed

Thank you @Daniel Korte for the patch.
I've committed the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nortmas’s picture

nortmas commented

I see that fix was committed to 8.x-1.x but the only RC version is available by now. There is no way to use 1.x.
From my point of view, it's very confusing and it looks like there are no bugs (opened tickets) and I can use this module without a doubt but in fact, it's not true.
At least, please, make the DEV release available with the latest fixes. Otherwise, people have to apply at least 3 patches to be able to use this version. Thank you.

mohit_aghera’s picture

mohit_aghera commented

Thanks, @nortmas for pointing out.
I am creating a new release right away with all the recent fixes.
As there are no other significant issues, I'll mark it as a stable release only.

Update:
Created a new release. https://www.drupal.org/project/config_export_ignore/releases/8.x-1.0

nortmas’s picture

nortmas commented

wow, it was super-fast :) thank you!