Problem/Motivation

Node owner exist or not check is missing, it can throws fatal error.

Proposed resolution

Throw NotFoundHttpException if node owner is not found.

Remaining tasks

Review path.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 node-revision-not-found-3104573-2.patch923 byteshardik_patel_12
#2 before-patch.png92.73 KBhardik_patel_12
#2 after-patch.png206.88 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new after-patch.png206.88 KB
new before-patch.png92.73 KB
new node-revision-not-found-3104573-2.patch923 bytes
kishor_kolekar’s picture

kishor_kolekar commented
Assigned: Unassigned » kishor_kolekar
hardik_patel_12’s picture

hardik_patel_12 commented
Title: Node Revision page for non-existing revision returns fatal error, should be 404 » Node owner check is missing
Issue summary: View changes
hardik_patel_12’s picture

hardik_patel_12 commented
Issue summary: View changes
kishor_kolekar’s picture

kishor_kolekar commented
Status: Needs review » Needs work

Hi @Hardik_Patel_12
I tried to apply your patch but not able to reproduce the issue please have a look.

Thanks !

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: kishor_kolekar » Unassigned
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Needs tests

I think this patch means that any node where the author has been deleted will give "page not found". Is this really the desired behaviour? If the node author has been deleted, shouldn't we still display the node, just without the author information?

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Closed (works as designed)