I noticed an error was produced when checking for coding standard violations:
phpcs --standard=DrupalPractice .
FILE: /var/www/html/drupal2/modules/social_auth_uber/src/UberAuthManager.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
33 | ERROR | The $_GET super global must not be accessed directly; inject the request.stack
| | service and use $stack->getCurrentRequest()->query->get('code') instead
----------------------------------------------------------------------------------------------------
Time: 82ms; Memory: 6MB
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | social_auth_uber-fix-coding-standards-3103906-4.patch | 2.17 KB | neel24 |
| #3 | social_auth_uber-fix-coding-standards-3103906-3.patch | 2.23 KB | neel24 |
| #2 | social_auth_uber-fix-coding-standards-3103906-2.patch | 2.23 KB | neel24 |
Comments
Comment #2
neel24 commentedI've attached a patch for fixing the error
Comment #3
neel24 commentedSorry, had wrongly commented ConfigFactory, below is the correct patch
Comment #4
neel24 commentedSorry, had forgotten to remove
var_dump. Attaching new patch.Comment #6
gvso