I noticed an error was produced when checking for coding standard violations:

phpcs --standard=DrupalPractice .

FILE: /var/www/html/drupal2/modules/social_auth_uber/src/UberAuthManager.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 33 | ERROR | The $_GET super global must not be accessed directly; inject the request.stack
    |       | service and use $stack->getCurrentRequest()->query->get('code') instead
----------------------------------------------------------------------------------------------------

Time: 82ms; Memory: 6MB

Comments

neel24 created an issue. See original summary.

neel24’s picture

Status: Active » Needs review
StatusFileSize
new2.23 KB

I've attached a patch for fixing the error

neel24’s picture

Sorry, had wrongly commented ConfigFactory, below is the correct patch

neel24’s picture

Sorry, had forgotten to remove var_dump. Attaching new patch.

  • gvso committed 37899dc on 8.x-2.x
    Issue #3103906 by neel24: Fix coding standards
    
gvso’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.