Closed (fixed)
Project:
Bootstrap DateTime Picker
Version:
8.x-1.2
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
27 Dec 2019 at 11:07 UTC
Updated:
18 Mar 2021 at 07:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Orestis Nerantzis commentedComment #3
b_sharpe commentedI'm not sure why these options are necessary in the first place? They are determining layout, not anything to do with the widget itself. The layout in my opinion should be left to the form in which the field exists.
That said, if there is a valid reason to have the widget use these classes on the wrapping elements, then I support the patch at minimum.
Comment #4
jb.fresh commentedThis patch seems to be a good path to fix some other issues with the layout that are introduced by the widget.
Comment #5
prashant.c@Orestis Nerantzis
I agree with @b_sharpe it a widget so do not need to add something for the layout but I tested it and found it could be useful sometimes, fixing a bit of layout issue of the field as well.
However there are few inputs :
1. Remove trailing spaces after $summary = []; and $elements = [];
2. Need not to translate integers.
3. Do not need extra single quotes in
"<div class='" . $element['#wrapper_class'] . "'>and<div class='" . $element['#column_size_class'] . "'>";Please fix, test these and resubmit the patch.
Thanks, nice work!
Comment #6
ayushmishra206 commentedI have made the changes requested in #5. please review
Comment #8
prashant.cThanks to all of you. Pushed and released with tag 8.x-1.5. Please check at your end and feel free to re-open this ticket if any issue found.