After following the Managing CKEditor plugins using composer(https://www.drupal.org/docs/8/core/modules/ckeditor/managing-ckeditor-pl...) document, I have updated my project related JSON.
This leads to mismatch the library file path so updating the path accordingly.

Comments

rahul.shinde created an issue. See original summary.

rahul.shinde’s picture

Assigned: rahul.shinde » Unassigned
Status: Active » Needs review
meichr’s picture

Status: Needs review » Closed (works as designed)

Hi @rahul.shinde, thank you for your input. But, if we would change the path to a hardcoded path like yours, many other installations would fail to recognise their Indentblock plugin after update.

For Drupal 9 there is a recommended way to find the plugin, but up to now there is no official recommendation to move the indentblock library to a subfolder of libraries. As the ckeditor maintainers have not reviewed the documentation page, you refer to, it cannot be considered official.

In another issue #3058017: Drupal 9 Deprecated Code Report, we changed the method of finding the plugin to the Drupal 8.9 / 9 recommended method.

meichr’s picture

Title: Update the Drupal root-relative js file path. » Add a special ckeditor plugin libraries directory to the search list for the js plugin.
Assigned: Unassigned » meichr
Status: Closed (works as designed) » Needs work
StatusFileSize
new2.23 KB

Reopening this issue as with the new version of the installer, we have a possibility for searching at more than one path for the Indentblock library and can add the path of the ckeditor documentation without breaking existing installations of the module.

During installation and runtime the ckeditor_indentblock module is searching for the Indentblock plugin at following places in that order:

  1. At the path of the current multisite: sites/domain.tld/libraries/indentblock/plugin.js
  2. At the drupal root path: libraries/indentblock/plugin.js
  3. At the path for ckeditor plugin libraries: libraries/ckeditor/plugins/indentblock/plugin.js
  4. At the path of the current profile: profiles/profile-name/libraries/ckeditor/plugins/indentblock/plugin.js

See attached patch.

  • meichr committed 915f490 on 8.x-1.x
    Issue #3103333 by rahul.shinde, meichr: Add the ckeditor plugin...
meichr’s picture

Status: Needs work » Fixed

Fixed.

meichr’s picture

Assigned: meichr » Unassigned

Remove assignment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.