When editing a machine name of a View Page (didn't check others) - An uppercase letter gives error text:
"Display name must be letters, numbers, or underscores only." This message while true, is also incomplete in describing the requirements.
Changing this from the words '... letters ...' to '... lowercase letters ...' will provide more useful information.

CommentFileSizeAuthor
#17 interdiff-12-17.txt782 bytesjungle
#17 3103010-17.patch1.7 KBjungle
#12 drupal-views_display_validation_error_fix-3103010-12.patch956 bytesandrewsizz
#12 drupal-views_display_validation_error_fix-3103010-12.patch956 bytesandrewsizz
#8 views_display_validation_error_fix-3103010-8.patch951 bytesno sssweat
#3 Views.png27.01 KBno sssweat

Comments

jshimota01 created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.9.x-dev
Component: User interface » views_ui.module
Priority: Normal » Minor

In Drupal 8 the Views module was added directly to core. As a result, this issue belongs in the core issue queue, hopefully someone will be able to help you there.

no sssweat’s picture

no sssweat commented
StatusFileSize
new Views.png27.01 KB

Was not able to reproduce on 8.8.5

not able to reproduce img

no sssweat’s picture

no sssweat commented
Status: Active » Postponed (maintainer needs more info)
no sssweat’s picture

no sssweat commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
no sssweat’s picture

no sssweat commented

When editing a machine name of a View Page (didn't check others)

I see now, it's the display machine name (the machine name under the advanced section).

no sssweat’s picture

no sssweat commented
Status: Closed (cannot reproduce) » Active
no sssweat’s picture

no sssweat commented
StatusFileSize
new views_display_validation_error_fix-3103010-8.patch951 bytes

I've created a patch

no sssweat’s picture

no sssweat commented
Status: Active » Needs review
nikunj.shah’s picture

nikunj.shah commented
Assigned: Unassigned » nikunj.shah
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work

Patch doesn't apply, so 'needs work' for that, but the change looks good

andrewsizz’s picture

andrewsizz commented
Assigned: nikunj.shah » Unassigned
Status: Needs work » Needs review
StatusFileSize
new drupal-views_display_validation_error_fix-3103010-12.patch956 bytes
new drupal-views_display_validation_error_fix-3103010-12.patch956 bytes
andrewsizz’s picture

andrewsizz commented

The last submitted patch, 12: drupal-views_display_validation_error_fix-3103010-12.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 12: drupal-views_display_validation_error_fix-3103010-12.patch, failed testing. View results

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue tags: +Novice

So the error string is tested in \Drupal\Tests\views_ui\Functional\ViewEditTest::testOtherOptions so that needs an update.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs work » Needs review
StatusFileSize
new 3103010-17.patch1.7 KB
new interdiff-12-17.txt782 bytes

Addressed #6

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Category: Bug report » Task
Status: Needs review » Reviewed & tested by the community

Marking this a task, since it is not actually a bug.

Looks good!

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • xjm committed 0e33627 on 9.1.x 
    Issue #3103010 by AndrewsizZ, No Sssweat, jungle, Lendude, jshimota01:...

  • xjm committed 8ceb91f on 9.0.x 
    Issue #3103010 by AndrewsizZ, No Sssweat, jungle, Lendude, jshimota01:...

  • xjm committed 5a71f0f on 8.9.x 
    Issue #3103010 by AndrewsizZ, No Sssweat, jungle, Lendude, jshimota01:...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

This is a good improvement. Since it changes a string, it's eligible for backport in beta, up to RC. So we're in time to get this into all of 9.1, 9.0, and 8.9. since those are in beta.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.