Looks like the module has no deprecated code usages, so we just need to mark it as compatible with D9.

So, add core_version_requirement: ^8 || ^9 to all info.yml file, and also add the composer.json definition per https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#5 views_geojson-d9_core_version_requirement-3102711-5.patch647 bytesjeffschuler
#2 updated-info-file.patch754 bytessahana _n

Comments

Sahana _N created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review
StatusFileSize
new updated-info-file.patch754 bytes

Please review the patch.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Category: Feature request » Task
Status: Needs review » Needs work
Issue tags: +Drupal 9 compatibility

Thanks @Sahana_N!

Shouldn't the requirements match in the two files? The doc you referenced says:

Please note you also need to add the same requirements from your info.yaml file in your composer.json file:

Anyway, we don't want to require ^8.7 for this module; some folks might still be on an earlier version of 8.x.

Question:

Looks like the module has no deprecated code usages

Have you verified this with Upgrade Status / drupal-check? (Not just that we don't have any @deprecated comments...?)

Also looks like there's an indentation whitespace issue in your change in composer.json.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented

Also, in composer.json the "drupal/core" requirement should go in the "require" section, not "require-dev".

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new views_geojson-d9_core_version_requirement-3102711-5.patch647 bytes

I've fixed the things I brought up above, and used drupal-check to verify no deprecated code.

  • jeffschuler committed 35e4a74 on 8.x-1.x 
    Issue #3102711 by Sahana _N, jeffschuler: Mark as compatible with Drupal...
jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Reviewed & tested by the community » Fixed

Committed.
Thanks @Sahana _N!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.