To support creation of the patches in cli with drush or/and drupal console it would be nice to have the logic in separate service rather than having it inside the Form class.

Form should just provide the user interface and the logic would be in the separate service that could be reused for other purposes.

The patch is attached.

CommentFileSizeAuthor
#2 decoupled-logic-service-3102075.patch23.89 KBa.dmitriiev

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev’s picture

a.dmitriiev commented
StatusFileSize
new decoupled-logic-service-3102075.patch23.89 KB
a.dmitriiev’s picture

a.dmitriiev commented

Also the patch fixes some problems with different configuration collections.

a.dmitriiev’s picture

a.dmitriiev commented
Status: Active » Needs review
ahebrank’s picture

ahebrank commented

Thanks for this -- appreciate the improvement over the MVP and will test it out shortly.

ahebrank’s picture

ahebrank commented
Status: Needs review » Fixed

I don't want to hold this up -- pushing this untested into the 8.x-2.x branch.

ahebrank’s picture

ahebrank commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.