The Typed Data .travis.yml file is still trying to run tests against Core 8.3, 8.4 and 8.5. The file needs to brought up to date with current Travis syntax, and make it run with Core 8.7, 8.8 and 8.9, updating phpunit, dropping PHP5.5 but adding PHP7.3.

I understand that the main development of this module takes place here on drupal.org, but it is useful for those who wish to test using Travis to have this build file available.

CommentFileSizeAuthor
#3 3101888-3.travis-and-phpcs.patch4.47 KBjonathan1055
#2 3101888-2.travis-and-phpcs.patch4.34 KBjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3101888-2.travis-and-phpcs.patch4.34 KB

Patch attached. It does include a change to phpcs.xml.dist, following #3074176: Allow extensions to be overridden in contrib phpcs.xml file so is worth testing here on drupal.org, even though the .travis.yml file will have no bearing on this test.

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new 3101888-3.travis-and-phpcs.patch4.47 KB

There is a problem when running the Core 8.7/PHP7.1 combination, where we get 52 functional test failures, all

PHPUnit\Framework\Exception: PHP Fatal error:  Class 'Drupal\Core\Test\TestDiscovery' not found in /home/travis/build/jonathan1055/typed_data/vendor/drupal/core/modules/simpletest/src/TestDiscovery.php on line 25

I have looked for a quick solution, but nothing found yet. Probably something to do with #2863055: Move TestDiscovery out of simpletest module, minimize dependencies. However, it is not critical that we have this particluar test combo, so the easiest thing is to remove it.

  • TR committed 7bf1441 on 8.x-1.x authored by jonathan1055 
    Issue #3101888 by jonathan1055: Update .travis.yml and phpcs.xml.dist
tr’s picture

tr commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.