Problem/Motivation

It seems like #2849628: Strange bar in View UI filters Modal when there are no filter options was only applied to Stable whereas it should have been applied to both, Views UI and Stable.

Proposed resolution

Copy the change to Views UI module so that the change can be shipped also in the new Stable 9 theme.

CommentFileSizeAuthor
#3 3101787-3.patch482 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Parent issue: » #2849628: Strange bar in View UI filters Modal when there are no filter options
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3101787-3.patch482 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Follow-up to #2849628: Copy change to Views UI » Follow-up to #2849628: Copy change to Views UI module
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +trivial patch

Good catch!

  • xjm committed 58bec68 on 9.0.x 
    Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views...

  • xjm committed 9bef736 on 8.9.x 
    Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views...

  • xjm committed b507e98 on 8.8.x 
    Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Oh yeah, even I can see that the original issue not including module CSS was an oops. Not sure why I didn't see it at the time... :P

The original issue was backported to 8.3.x during its alpha phase. The only possibility of disruption here now is for themes that don't even extend Stable, and this is a straight-up bugfix for them anyway, so I think it's also safe to backport for an 8.8.x patch release. So, I've committed this to 9.0.x, and cherry-picked it to both 8.9.x and 8.8.x.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.