Closed (fixed)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Dec 2019 at 06:35 UTC
Updated:
5 Jan 2020 at 01:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tr commentedAs outlined in the parent issue, we need a D8 replacement for the D7
watchdog()function, which was used to send messages to the core Drupal dblog. Or course, we know how to do this, with a simple logger channel.We first have to finish at least part of #3101194: Rename logger.channel.rules to logger.channel.rules_debug, because the name
logger.channel.rulesis already in use ...This issue is to:
logger.channel.rulesservice, using the default logger channel implementation (not our own class).logger.channel.rulesare checked to determine if they are really intended to log to the the database - in which case they should continue to use the newlogger.channel.rules- or were intended to use the Rules debug channel (in-memory logs) - in which case they should be switched to using the newlogger.channel.rules_debugwatchdog()was used. Make sure that all these uses (actions/conditions, enabling/disabling rules, etc.) are ported to D8 using the newlogger.channel.rules.Comment #3
tr commented1) and part of 2) was done by #3101194: Rename logger.channel.rules to logger.channel.rules_debug.
The patch here covers the rest.
watchdog()seems to have been used only for important system things, like a rule was enabled/disabled, email was sent, an IP address was banned, things of that nature. Plus,watchdog()was used when debug logging of Rules execution was turned on - this debug case will be covered in #3101198: [meta] Implement conditional logging and on-screen rendering in RulesDebugLoggingChannel and not here.Comment #4
tr commentedFixing the fails ...
Comment #5
tr commentedSign, and now without the coding standards problems ... It's getting late ...
Comment #7
tr commentedCommitted.
Comment #8
tr commented