First off, thank you so much for contributing this code. It works great once the following two errors are addressed:

Problem/Motivation

PHP Fatal error: Declaration of Drupal\migrate_source_ical\Plugin\migrate\source\Ical::count() must be compatible with Drupal\migrate\Plugin\migrate\source\SourcePluginBase::count($refresh = false) in [path-to-drupal]/modules/contrib/migrate_source_ical/src/Plugin/migrate/source/Ical.php on line 158

Error: Class '\Drupal\migrate_source_ical\Plugin\migrate\ICALReader' not found in [path-to-drupal]/modules/contrib/migrate_source_ical/src/Plugin/migrate/source/Ical.php on line 98

Proposed resolution

Change the former function definition to count($refresh = false), and change the capitalization of the latter class to IcalReader to match its filename.

I'll attach my patch momentarily. Thank you again!

CommentFileSizeAuthor
#2 3101074-0-migrate_source_ical-typos.patch1.3 KBbenstallings

Issue fork migrate_source_ical-3101074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

BenStallings created an issue. See original summary.

benstallings’s picture

benstallings commented
StatusFileSize
new 3101074-0-migrate_source_ical-typos.patch1.3 KB
benstallings’s picture

benstallings commented
Title: Ical::count() must be compatible with SourcePluginBase::count($refresh = false) » minor typos or compatibility errors
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Kind of a major bug as the class names need to match.

Looks good to me.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: benstallings » Unassigned

As a reminder, the "assigned" field is for indicating that you're currently working on something, once you finish the work the field should be changed to "unassigned"; maintainers can identify by reading through the issue who worked on it to give the appropriate attribution.

arulan_pari made their first commit to this issue’s fork.

arulan_pari opened merge request !1

arulan_pari closed merge request !1

das.gautam made their first commit to this issue’s fork.

das.gautam opened merge request !3

  • das.gautam committed 806d02e4 on 8.x-1.x 
    Issue #3101074 by benstallings, damienmckenna: Fix minor typos and...
das.gautam’s picture

das.gautam commented

Thank you @benstallings @damienmckenna

das.gautam’s picture

das.gautam commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.