I got an error when try to click Preview link.

LogicException: Render context is empty, because render() was called outside of a renderRoot() or renderPlain() call. Use renderPlain()/renderRoot() or #lazy_builder/#pre_render instead. in Drupal\Core\Render\Renderer->doRender() (line 263 of /core/lib/Drupal/Core/Render/Renderer.php).

CommentFileSizeAuthor
#4 3100731-4.patch2.06 KBankush_03
#2 focal_point-replace-deprecated-render-func-3100731-2.patch554 bytesugolek

Comments

lebster created an issue. See original summary.

ugolek’s picture

ugolek commented
Status: Active » Needs review
StatusFileSize
new focal_point-replace-deprecated-render-func-3100731-2.patch554 bytes

Patch is attached.

ugolek’s picture

ugolek commented
Issue summary: View changes
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3100731-4.patch2.06 KB

Adding updated patch !

Remove direct service calls, add renderer service as an dependency injection.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
bleen’s picture

bleen commented

Except for the minor whitespace issue in #4 this looks good to me ... I'd like at least one other review and Im ready to commit this

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Controller/FocalPointPreviewController.php
@@ -141,7 +151,7 @@ class FocalPointPreviewController extends ControllerBase {
     ];
 
-    $html = render($output);
+    $html = $this->renderer->renderPlain($output);

this in theory drops cacheability information, but afaik this is a backend and POST-only (at least until ajax will support GET) request, so it's not cached anyway. So probably fine :)

Note. render() isn't technically deprecated but should be. The real difference here is changing $renderer->render() to $renderer->renderPlain()

bleen’s picture

bleen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.