The message in the popup is not translated the right way and the one shown via messenger() not translated at all.
Also we should filter for XSS.

CommentFileSizeAuthor
#3 3100622-translate_messages-3.patch2.52 KBytsurk
#2 3100622-translate_messages-2.patch2.23 KBytsurk

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new 3100622-translate_messages-2.patch2.23 KB

Here a patch doing it right.

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new 3100622-translate_messages-3.patch2.52 KB

Sorry .. missed a line.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Active » Needs review
deaom’s picture

deaom commented
Status: Needs review » Reviewed & tested by the community

Hi @ytsurk, it would be nice to have some steps how to reproduce the issue so it is easier to test the solution. So without the patch the strings do not appear in the User interface translation so they are never translated. When applying the patch, which does apply, the strings are available and the correct translation is shown. About the XSS, not sure if this is the place, as the message can be entered only by a registered user, but who I am to say.

ytsurk’s picture

ytsurk
Location Switzerland
commented

Thank you for testing and reviewing @DeaOm.

Yes the problem was, that the text was given to the translation service as placeholder, which does not make it show up in the translation UI and is not translatable in any way. Thus it is untranslatable.

And now it is translatable in the translation UI as soon as it showed up once in the frontend.

So - this are the steps on how to reproduce.

Regarding XSS, it's good (recommended) ((mandatory)) practice to sanitize user input! Do not trust registered users, even user 1! So this needs to go in!

  • boshtian committed 468ebab on 8.x-1.x authored by ytsurk 
    Issue #3100622 by ytsurk: Logout messages not translated the right way
boshtian’s picture

boshtian commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.