Problem/Motivation

There is a d6 and d7 ValidateMigrationStateTest both of which use ValidateMigrationStateTestTrait::testMigrationState() but that actually checks both the d6 and d7 migration states whereas it should only do one. Plus the test will be a bit easier to read without the version index in all the arrays.

Proposed resolution

Get the legacy version from the source database.

Remaining tasks

Patch, review, commit.

CommentFileSizeAuthor
#3 3100190-2.patch8.67 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes
quietone’s picture

Status: Active » Needs review
FileSize
8.67 KB

And here is the patch, all straightforward.

mikelutz’s picture

Status: Needs review » Reviewed & tested by the community

This makes sense and seems straightforward. No point in running the same test twice.

alexpott’s picture

Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed 5367f8a5af to 9.0.x and d0476bbefc to 8.9.x. Thanks!

Will backport to 8.8.x when the freeze is over as this is a test only change.

  • alexpott committed 5367f8a on 9.0.x
    Issue #3100190 by quietone: Change ValidateMigrationStateTestTrait to...

  • alexpott committed d0476bb on 8.9.x
    Issue #3100190 by quietone: Change ValidateMigrationStateTestTrait to...

  • alexpott committed 02c560d on 8.8.x
    Issue #3100190 by quietone: Change ValidateMigrationStateTestTrait to...
alexpott’s picture

Status: Patch (to be ported) » Fixed

We're not in a freeze.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.