Modal is not working on alias page

Interesting @hardik_patel_12

Very good!

We need to check the tests right?! The test was failed =/

Yes, of course.

Thalles created these tests but I didn't check it yet.

@thalles: please, can you help with this?

Hello, I have tested the patch and it works fine.

1. Inside ADVANCED option
On button click, if you want to redirect to internal or external URL then that URL needs to add in OK Button Redirect URL
field

a. External URL

b. Internal URL

2. After successfully done Add modal or Edit modal, will be able to see a pop-up

3. On button click, it will redirect to a link provided in advanced option.

Yeah. Makes sense.

This test is related to #3100534: Redirect after modal submit

The current issue we need to check the reason that the automated tests are failing.

@hardik_patel_12 @RenatoG, Patch is not getting applied properly. Think so there may be some new changes got added.

As per the above comments moving this issue.

@hardik_patel_12 @RenatoG
Apologies for my comment #8
I have accidentally added a comment on this issue. and comment #8 is for https://www.drupal.org/project/modal_page/issues/3100534 issue.

Relax, no problems

Thank you all for your help

Follow a new patch and the interdiff.

There were some changes, so I ask you to check

+++ b/src/ModalPage.php
@@ -208,7 +219,8 @@ class ModalPage {
-    $currentPath = ltrim($this->request->getRequestUri(), '/');
+    // $currentPath = ltrim($this->request->getRequestUri(), '/');
+    $currentPath = $this->request->getRequestUri();

This change broken the test.

+++ b/src/Form/ModalForm.php
@@ -130,6 +130,23 @@ class ModalForm extends ContentEntityForm {
+      if ($trim_url !== '<front>' && $trim_url[0] !== '/') {

And I change this line to allow the

Thank You @thalles for the patch. Just an suggestion to follow the patch naming pattern.
Updated the patch with some coding standard fixes.

Hello guys, congrats on the job! Amazing!

I saw a detail:

On this part $aliasPath[] = \Drupal::service('path.alias_manager')->getPathByAlias($path);

We can use dependency injection stead of \Drupal::service('path.alias_manager') that's right?

Example:

$this->pathAliasManager->getPathByAlias($path);

Hey guys,
I noticed the line ->condition('pages', NULL, 'IS') removed from getModalIds() .
This is causing the modal not to show in all pages if the pages field is left blank.
Can this be added back?

Thanks @wil2091!
I will check this!