Problem/Motivation

drupal-check views_field_view  

4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------
  Line   src/Tests/ViewFieldUITest.php                                                                                   
 ------ -------------------------------------------------------------------------------------------------------------
  15     Class Drupal\views_field_view\Tests\ViewFieldUITest extends deprecated class Drupal\views_ui\Tests\UITestBase:  
         in drupal:8.4.0 and is removed from drupal:9.0.0.                                                               
         Use \Drupal\Tests\views_ui\Functional\UITestBase.                                                               
  42     Call to method setUp() of deprecated class Drupal\views_ui\Tests\UITestBase:                                    
         in drupal:8.4.0 and is removed from drupal:9.0.0.                                                               
         Use \Drupal\Tests\views_ui\Functional\UITestBase.                                                               
 ------ --------------------------------------------------------------------------------------------------------------
                                                                                                                        
 [ERROR] Found 2 errors
CommentFileSizeAuthor
#19 3100149-drupal-9-compatibility.4.patch3.19 KBxem8vfdh
#14 3100149-drupal-9-compatibility.3.patch3.16 KBxem8vfdh
#13 3100149-drupal-9-compatibility.2.patch2.82 KBxem8vfdh
#10 3100149-drupal-9-compatibility.patch757 bytesxem8vfdh
#9 drupal_9_compatibility_diff.patch757 bytesxem8vfdh
#8 drupal_9_compatibility.patch1.08 KBxem8vfdh
#3 3100149-3.patch411 bytesjohn cook

Comments

gmangones created an issue. See original summary.

hash6’s picture

hash6 commented
Assigned: Unassigned » hash6
john cook’s picture

john cook commented
Issue tags: +ContributionWeekend2020
StatusFileSize
new 3100149-3.patch411 bytes

I've created a patch to fix the reported errors.

Post patch results:

$ ./vendor/bin/drupal-check modules/contrib/views_field_view/
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                       
                                               
 [OK] No errors
john cook’s picture

john cook commented
Status: Needs work » Needs review
hash6’s picture

hash6 commented
hash6’s picture

hash6 commented
Assigned: hash6 » Unassigned
xem8vfdh’s picture

xem8vfdh commented

is this ready to go?

xem8vfdh’s picture

xem8vfdh commented
StatusFileSize
new drupal_9_compatibility.patch1.08 KB

(deleted)

xem8vfdh’s picture

xem8vfdh commented
StatusFileSize
new drupal_9_compatibility_diff.patch757 bytes

sorry, new to this... trying again with drupal_9_compatibility_diff.patch (

xem8vfdh’s picture

xem8vfdh commented
StatusFileSize
new 3100149-drupal-9-compatibility.patch757 bytes

One last try, following drupal patching instructions: 3100149-drupal-9-compatibility.patch

xem8vfdh’s picture

xem8vfdh commented
xem8vfdh’s picture

xem8vfdh commented
xem8vfdh’s picture

xem8vfdh commented
StatusFileSize
new 3100149-drupal-9-compatibility.2.patch2.82 KB

3100149-drupal-9-compatibility.2.patch

xem8vfdh’s picture

xem8vfdh commented
StatusFileSize
new 3100149-drupal-9-compatibility.3.patch3.16 KB

3100149-drupal-9-compatibility.3.patch

xem8vfdh’s picture

xem8vfdh commented
xem8vfdh’s picture

xem8vfdh commented
Status: Needs review » Reviewed & tested by the community

drupal-check is passing, as are unit tests on 7.1. Since I'm not sure anyone will every review this, or if this module is even maintained, I am marking this as reviewed (by myself).

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs work

Let's add the changes from the patch from #3130966: Drupal 9 readiness here as well.

xem8vfdh’s picture

xem8vfdh commented

greatm go for it!

xem8vfdh’s picture

xem8vfdh commented
StatusFileSize
new 3100149-drupal-9-compatibility.4.patch3.19 KB

never mind, I've attached 3100149-drupal-9-compatibility.4.patch to take care of this, please review @jibran

xem8vfdh’s picture

xem8vfdh commented
Status: Needs work » Needs review
xem8vfdh’s picture

xem8vfdh commented

@jibran can you review again, thanks!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Looks good now. Thanks!

jibran credited ravimane23.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Adding @ravimane23 to credit list from #3130966: Drupal 9 readiness.

  • jibran committed 442ab89 on 8.x-1.x authored by xeM8VfDh 
    Issue #3100149 by xeM8VfDh, John Cook, jibran, ravimane23: Drupal 9...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x. Thanks all!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

We miesed one here modules/views_field_view/tests/views_field_view_test_config/views_field_view_test_config.info.yml

xem8vfdh’s picture

xem8vfdh commented

thanks @jibran, see 3138306

xem8vfdh’s picture

xem8vfdh commented
Related issues: +#3138306: Note drupal 9 support in test config file

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.