Very similar to this issue #3094397: Attributes key missing hash or pound sign in seven, it appears another hash is missing in the same file (seven.theme), a few lines down. When attempting to add a remote video to a field, User error: "0" is an invalid render array key in Drupal\Core\Render\Element::children() was showing up the dblog several times.
Adding the hash here $form['#attributes']['class'][] = 'media-library-add-form--oembed'; stopped the error from appearing.
Steps to reproduce:
On a Drupal 8.8 site, create an entity reference field (media) that allows remote video. Add the field to a content type. Create a node of that content type and attempt to add a remote video to the field you made. Look at the dblog to see the error.
What behavior were you expecting?
I was expecting there to be no errors in the dblog.
What happened instead?
Several php errors appear in the dblog every time an attempt is made to add a remote video to this field.
I have a patch that adds the missing hash.
Edited to add: this is the first time I've created a patch and am clearly getting the comment numbers wrong. If this is an issue, please let me know and I can fix.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | elements.PNG | 4.32 KB | uv516 |
| #17 | User error1 is an invalid render array key.PNG | 14.92 KB | uv516 |
| #17 | User error 0 is an invalid render array key.PNG | 16.29 KB | uv516 |
| #3 | 3099441-2.patch | 687 bytes | pjudge |
Comments
Comment #2
pjudge commentedComment #3
pjudge commentedComment #4
pjudge commentedComment #5
spokje@pjudge Thanks for the patch, looks like this is a bug in Seven, but we would need a test that proves:
- Something goes wrong without the patch
- The same thing doesn't go wrong with the patch applied.
Tip: If you want TestBot to have a look if your patch doesn't break any of the already existing tests: Set the status of the issue to Needs Review.
That automagically fires up TestBot and runs all existing tests on the latest Core dev-version with your latest patch applied, and should any test fail, puts it back to Needs Work.
I've done just that, and added a "Needs tests" tag for this patch, well...., needing tests :)
The incorrect comment number in your patches isn't really a "big thing", it's just convenient when the number in the patch-filename matches the comment it's posted in, especially if an issues becomes very long.
Next time: Just look at the latest existing comment-number and add 1 when uploading a new patch :)
Comment #6
pjudge commented@Spokje, thank you so much for the info and for the help!
Comment #7
peterwcm commentedPatch #3 works for me. It fixes the error logs and oembed video can be added on-the-fly using the media library ajax form (without the patch, you can only select an existing video, the video add form was broken due to the mentioned error)
Comment #8
peterwcm commentedComment #9
alexpottI've tested this manually. We didn;t require a test for #3094397: Attributes key missing hash or pound sign in seven - I think the fix here is obvious enough to move on. Even if I change the default theme from classy to seven and run \Drupal\Tests\media_library\FunctionalJavascript\WidgetOEmbedTest it is not failing - so to test this we'd have to add an assert on the class name which feels OTT.
@Spokje thanks for the good comment about our process and you are 100% correct that bug fixes require tests but we also have committer discretion so I'm going to use that here to get this fixed as quickly as possible so people can enjoy a media library with one less bug in 8.8.1.
If someone wants to file a followup to add testing of all of the media library hooks in seven and other themes I've very +1 to that.
Crediting @Spokje and @peterwcm for issue comments and participation.
Committed and pushed aeeb3bcd36 to 9.0.x and 6c8d11fc75 to 8.9.x and dd1f6e623d to 8.8.x. Thanks!
Comment #13
spokjeThanks @alexpot for the committer discretion, I prefer fixed bugs (if a Big Brain judges it needs no tests that is).
Foremost: Thanks to @pjudge of course :)
Comment #15
tudor.vlas commentedHi
I still encounter this issue while using D8.9.3.
Anybody else that still has this problem?
Comment #16
esod commentedI'm encountering this issue with Drupal 8.8.10 with the Insert module. With the core CKEditor, no error message.
Comment #17
uv516 commentedI have studied the error in older versions of Seven. the hash is now correct. But I still get the error.
The error can show up on different pages, but consequent on the "admin/reports/updates" page.
I am using the newest update of core (9.1.2) and the theme Seven as admin-theme.
In "\core\lib\Drupal\Core\Render\Element.php" the error is shown by
trigger_error(new FormattableMarkup('"@key" is an invalid render array key', ['@key' => $key]), E_USER_ERROR);.The function "public static function children(array &$elements, $sort = FALSE) ", line 71.
I have tested $elements, $key and $value. The result is shown in attached pictures.
It is obviously a mistake that the first 5 values are not arrays.
I don't know why it is an error. It look like there is nothing wrong else.
On my own sites I REM the trigger_error line, but there must be a reason for the error to appear.:
# trigger_error(new FormattableMarkup('"@key" is an invalid render array key', ['@key' => $key]), E_USER_ERROR);Comment #18
uv516 commentedAm I the only one who still have this error?
Comment #19
uv516 commentedUpdated to Drupal 9.1.6:
Still the same text:
-------------------------------
User error: "0" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).
Drupal\Core\Render\Element::children(Array, 1) (Line: 402)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 109)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->block_messages(Array, Array) (Line: 182)
Twig\Template->displayBlock('messages', Array, Array) (Line: 43)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('core/themes/seven/templates/classy/misc/status-messages.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('status_messages', Array) (Line: 431)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 156)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 157)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 171)
Drupal\Core\Render\Renderer->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 547)
Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 381)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)
User error: "1" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).
Drupal\Core\Render\Element::children(Array, 1) (Line: 402)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 109)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->block_messages(Array, Array) (Line: 182)
Twig\Template->displayBlock('messages', Array, Array) (Line: 43)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('core/themes/seven/templates/classy/misc/status-messages.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('status_messages', Array) (Line: 431)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 156)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 157)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 171)
Drupal\Core\Render\Renderer->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 547)
Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 381)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)
User error: "2" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).
Drupal\Core\Render\Element::children(Array, 1) (Line: 402)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 109)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->block_messages(Array, Array) (Line: 182)
Twig\Template->displayBlock('messages', Array, Array) (Line: 43)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('core/themes/seven/templates/classy/misc/status-messages.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('status_messages', Array) (Line: 431)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 156)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 157)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 171)
Drupal\Core\Render\Renderer->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 547)
Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 381)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)
User error: "3" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).
Drupal\Core\Render\Element::children(Array, 1) (Line: 402)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 109)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->block_messages(Array, Array) (Line: 182)
Twig\Template->displayBlock('messages', Array, Array) (Line: 43)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('core/themes/seven/templates/classy/misc/status-messages.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('status_messages', Array) (Line: 431)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 156)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 157)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 171)
Drupal\Core\Render\Renderer->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 547)
Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 381)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)
User error: "4" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).
Drupal\Core\Render\Element::children(Array, 1) (Line: 402)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 109)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->block_messages(Array, Array) (Line: 182)
Twig\Template->displayBlock('messages', Array, Array) (Line: 43)
__TwigTemplate_8ebaf14c18ff733f784bf2faa8ae0ac007b1963893a3ec5b545be4f216ba8052->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('core/themes/seven/templates/classy/misc/status-messages.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('status_messages', Array) (Line: 431)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 156)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 157)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 171)
Drupal\Core\Render\Renderer->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=Drupal%5CCore%5CRender%5CElement%5CStatusMessages%3A%3ArenderMessages&args%5B0%5D&token=_HAdUpwWmet0TOTe2PSiJuMntExoshbm1kh2wQzzzAA', Array) (Line: 547)
Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 381)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)
Comment #20
dqdIs ...
PHP Fatal error: "step" is an invalid render array key in web/core/lib/Drupal/Core/Render/Element.php on line 98in parity here? (Drupal 9.3) Or is this another issue? Cannot reopen for review so I risk to open another one.
Comment #21
hockey2112 commentedThis is the error I am receiving. How can I fix this issue? It results in 10+ log entries every time it occurs, takes up a lot of space.
User error: "0" is an invalid render array key in Drupal\Core\Render\Element::children() (line 98 of /home3/mysite/public_html/core/lib/Drupal/Core/Render/Element.php)
Comment #22
rick hood commentedI am getting this same error:
User error: "0" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of /code/web/core/lib/Drupal/Core/Render/Element.php)Steps to reproduce:
1. go here /update.php
2. click the link to go to home page after updates run, or even if no updates run
3. site is now borked until I clear cache on the Pantheon dashboard
This may or may not be related to the issue where Search API would not update, see this: https://www.drupal.org/project/search_api/issues/3247781#comment-14381536
I was having that issue where updates would error for 8.x-1.21. I updated to 8.x-1.23, and the updates ran OK now, but I still get the error above.
Comment #23
hockey2112 commentedThis patch/fix appears to have fixed this issue for me: https://www.drupal.org/project/skeletontheme/issues/3275683#comment-1459...