Problem/Motivation

For custom/contrib database drivers and extensions it is very difficult implement $connection->query() and $connection->query_range() queries.

Proposed resolution

Change all $connection->query() and $connection->query_range() to $connection->select() queries.

Remaining tasks

  1. Create change record mentioning all deprecated $connection->query() and $connection->query_range() methods
  2. Create a patch with the desired changes.

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

todo

Comments

daffie created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#2994904: Convert query('SELECT ... FROM {xxx}') to select('xxx')->... in tests

This was also discussed in #2994904: Convert query('SELECT ... FROM {xxx}') to select('xxx')->... in tests, see #8 for example, but finally rejected.

daffie’s picture

daffie commented
Related issues: +#2786811: Document that Database/Connection::escapeLike() does not work when used with Database/Connection::query() and Database/Connection::queryRange()

Discussed with @alexpott on Slack. It was his idea. We were discussing how to best inform contrib/other developers how not to use db_like() any more.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2988018: [PP-1] Performance issues with path alias generated queries on PostgreSQL
daffie’s picture

daffie commented

@andypost: Could you explain why you think #2988018: [PP-1] Performance issues with path alias generated queries on PostgreSQL is related to this issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented

@daffie because using query with hook alter will slow it down much more

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.