Problem/Motivation

The purgeDeletedWorkspacesBatch method of the workspaces manager is implemented, used and has an inheritdoc block, but it is not present in the WorkspaceManagerInterface. This causes problems when trying to decorate (or swap) the service.

Proposed resolution

Add purgeDeletedWorkspacesBatch to WorkspaceManagerInterface

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

purgeDeletedWorkspacesBatch implemented by the WorkspaceManager has been added to WorkspaceManagerInterface.

CommentFileSizeAuthor
#4 3098707-4.patch594 bytesblazey
#3 3098707-3.patch551 bytesblazey
#2 3098707-2.patch551 bytesblazey

Comments

blazey created an issue. See original summary.

blazey’s picture

blazey commented
Assigned: blazey » Unassigned
Status: Active » Needs review
StatusFileSize
new 3098707-2.patch551 bytes
blazey’s picture

blazey commented
StatusFileSize
new 3098707-3.patch551 bytes
blazey’s picture

blazey commented
StatusFileSize
new 3098707-4.patch594 bytes

Patches generated from the composer template don't apply :(

leksat’s picture

leksat commented
Status: Needs review » Reviewed & tested by the community

Thanks @blazey. Looks good!

amateescu’s picture

amateescu commented

Looks good to me as well, +1 for RTBC :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

As an experimental module backported to 8.8.x - the only affected contrib module already implements the method - see http://grep.xnddx.ru/node/29760192. So it appears that things that are implementing this interface already have to implement the method to work.

Committed and pushed a8d43caa6a to 9.0.x and c2423dfd7b to 8.9.x and 2d710d0b45 to 8.8.x. Thanks!

  • alexpott committed a8d43ca on 9.0.x 
    Issue #3098707 by blazey: Add purgeDeletedWorkspacesBatch to the...

  • alexpott committed c2423df on 8.9.x 
    Issue #3098707 by blazey: Add purgeDeletedWorkspacesBatch to the...

  • alexpott committed 2d710d0 on 8.8.x 
    Issue #3098707 by blazey: Add purgeDeletedWorkspacesBatch to the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.