Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
2 Dec 2019 at 18:12 UTC
Updated:
11 Jan 2020 at 10:39 UTC
Jump to comment: Most recent
Comments
Comment #2
rosemaryreilmanHi! Thanks for your contribution. Right off the bat, the project name is
html_importerbut your code useshtml_import. It would be easier for users downloading and using your site to stay consistent with the naming.Also there are several things to check on your PAReview and to fix. https://pareview.sh/pareview/https-git.drupal.org-project-html_importer
Comment #3
rosemaryreilmanAdded pareview link to main issue body
Comment #4
pratikshad commentedHi @rosemarystanley, I have addressed your comments. please check and confirm if there will any further improvement requires.
Comment #5
pratikshad commentedComment #6
avpaderno8.x and dev are wrong names for branches. A correct one would be 8.x-1.x, for example. A new branch needs to be created, made the default one, and the other branches need to be removed.
Comment #7
avpadernoComment #8
pratikshad commentedBranch name updated as per the suggestion
Comment #9
pratikshad commentedComment #10
pratikshad commentedComment #11
pratikshad commentedhi @kiamlaluno @coltrane anyone please help me for further process, how can I make my contributed module under security advisory policy.
Comment #12
avpadernoComment #13
pratikshad commentedhi @kiamlaluno,
Please suggest if any further action required to be taken on it.
Regards,
Pratiksha dubey
Comment #14
avpadernoWe are just waiting for reviews.
Comment #15
klausiComment #16
klausiThanks for your contribution!
Review of the 8.x-1.x branch:
Did not see any security issue otherwise, looks good to me!
Comment #17
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #18
avpaderno