Patch after phpcs, phpcbf and a bit of manual cleaning.

Opens a bit the question on #2892160-15: Provide Fraction targets for Feeds integration regarding typing on the Fraction class, this patch is loosely typing/assuming numerator and denominator to be ints (not strings) and value/decimal to be float.

CommentFileSizeAuthor
#4 3097812-4.patch11.27 KBpcambra
#2 3097812-2.patch12.7 KBpcambra

Comments

pcambra created an issue. See original summary.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3097812-2.patch12.7 KB
m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Needs review » Needs work

Can you separate the coding standards portions and the int/string changes to consider them separately?

We use BC Math for arithmetic where possible, which uses strings instead of floats. But it may still make sense to use ints in some places. I'd like to separate it out so that I can think it through apart from other changes.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 3097812-4.patch11.27 KB

Sure thing, let's open a separate issue for the fraction typing

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Needs review » Fixed

Merged - thanks @pcambra!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.