Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Nov 2019 at 18:09 UTC
Updated:
13 Jan 2020 at 23:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vernitYou need to resolved raise in PAReview. Important issue related to dependency namespace into info.yml
like :
drupal:nodeComment #3
vernitComment #4
vernitComment #5
jonnyeom commentedVernit,
Thanks for those updates.
I resolved all of the warnings from PAReview.
https://pareview.sh/pareview/https-git.drupal.org-project-file_delete.git
Could you take a look again?
Comment #6
avpadernoThank you for applying! I added the Git instructions for non-maintainer users.
Comment #7
mostepaniukvmHi @jonnyeom,
Thanks for contributing!
I checked the code and found some minor remarks.
1. I think will be useful to specify that $entity is an instance of FileInterface for this form. You can add
2. I don't sure if there is a reason to declare $fileUsage property as private. Maybe declare it as protected will be enough?
I hope my remarks have a sense.
Comment #8
jonnyeom commented@mostepaniukvm
Both really good ideas, especially since I am using
FileInterfacespecific methods.I pushed those updates and re-ran the pareview
Many thanks!
Comment #9
klausiThanks for your contribution!
Did not see any security issues, looks good to me!
Comment #10
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #11
jonnyeom commentedThanks everyone for the review!
@kiamlaluno Do you know how long it takes for the changes to show?
And yes, I think I may begin assisting with the review process.
@klausi Solid point. I will be updating that.
Comment #12
klausi@jonnyeom: you need to edit the project page and opt into security advisory coverage yourself.
Comment #13
avpaderno@klausi is correct: We edit the user accounts to make users able to opt into security coverage for every project they create, but that requires they edit their projects. There is a Security advisory coverage setting, on https://www.drupal.org/node/3091257/edit.
Comment #14
jonnyeom commentedFound it.
Thanks @klausi and @kiamlauno.
This was a solid review process
Comment #15
klausiThank you! Please also note that unstable alpha and beta releases are not covered by the drupal security team, so best release a stable version next.