Where is conflict with Yandex Maps module: Swapped Latitude and Longitude values on FieldFormatter. See #9.

I think better not change default coordorder value, but it this case in Yandex Maps module we should to swap lat and lot in all geometric figures. And it is problem.
But if add the coordorder parameter in this module we should change only single line :)

Patch will be attached.

CommentFileSizeAuthor
#20 interdiff.3096776.19-20.txt1.93 KBsuper_romeo
#20 3096776-20.geolocation.Conflict-with-YandexMaps.patch4.33 KBsuper_romeo
#19 3096776-19.geolocation.Conflict-with-YandexMaps.patch2.67 KBsuper_romeo
#18 3096776-18.geolocation.Conflict-with-YandexMaps.patch1009 bytessuper_romeo
#15 3096776-15.geolocation.Conflict-with-YandexMaps.patch2.77 KBsuper_romeo
#2 3096776-2.geolocation.Conflict-with-YandexMaps.patch1.35 KBsuper_romeo

Comments

super_romeo created an issue. See original summary.

super_romeo’s picture

super_romeo commented
Status: Active » Needs review
StatusFileSize
new 3096776-2.geolocation.Conflict-with-YandexMaps.patch1.35 KB
super_romeo’s picture

super_romeo commented
Status: Needs review » Needs work

My patch is beginning and it need to make some other changes in code.
So for now I will just not put this 2 formatters together on same page.

christianadamski’s picture

christianadamski commented
Status: Needs work » Postponed (maintainer needs more info)

So, commit the path or not?

super_romeo’s picture

super_romeo commented

My patch is incomplete. Need more work.

christianadamski’s picture

christianadamski commented

A side question: there is an issue with a patch attached for adding a Yandex based field widget.

That patch also alters how lat/lon are retrieved. Could you take a look at that patch?

super_romeo’s picture

super_romeo commented

Sure. I can look at. What patch do you talking about?

christianadamski’s picture

christianadamski commented

https://www.drupal.org/project/geolocation/issues/3100794

super_romeo’s picture

super_romeo commented

From the very beginning.
In initialisation URL https://api-maps.yandex.ru there is parameter coordorder. By default it's value is latlong. And it is convenient to set placemarks in usual manner (e.g. new Placemark(lat,lon);). But in this case we should pass all geometric shapes in same manner (e.g. Point(Y X)) because of lat is Y and lon=X) and Yandex Maps module must convert ALL shapes (Points, Polygons, Multipolygons, ...) from "X,Y" to "Y,X" order. And I didn't found the ready-to-use converter.

In for compatibility we can set coordorder=longlat and change the order of (lat,lon) to (lon,lat) in all places. It would be much easy I guess.

Patch in #8 looks good and in case of coordorder=longlat all (lat,lon) places should be just changed to (lon, lat) order too.

christianadamski’s picture

christianadamski commented

Hey, what about this issue? Just wait? Still relevant? Close?

super_romeo’s picture

super_romeo commented

If you agree with coordorder=longlat I can make a patch.

christianadamski’s picture

christianadamski commented

Yeah, I can add the Parameter myself, no problem. But is it useful? Is there something broken right now? Should we write a test for that?

super_romeo’s picture

super_romeo commented

Is there something broken right now?

No. This change is required for using geolocation yandex map and geofield yandex map on the same page.
I guess test is not required.
In patch we need to set this parameter and swap lat and lon in new Placemark(lat,lon) and other places.

christianadamski’s picture

christianadamski commented

Ok. Well, you decide as you see fit. You can close this issue, or leave postponed until a patch. Your call :)

super_romeo’s picture

super_romeo commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 3096776-15.geolocation.Conflict-with-YandexMaps.patch2.77 KB

  • super_romeo authored 6850a2f on 8.x-3.x 
    Issue #3096776 by super_romeo: Conflict with Yandex.Maps
christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed

Comitted

super_romeo’s picture

super_romeo commented
Status: Fixed » Needs review
StatusFileSize
new 3096776-18.geolocation.Conflict-with-YandexMaps.patch1009 bytes

One more fix.

super_romeo’s picture

super_romeo commented
StatusFileSize
new 3096776-19.geolocation.Conflict-with-YandexMaps.patch2.67 KB

And one more fix.

super_romeo’s picture

super_romeo commented
StatusFileSize
new 3096776-20.geolocation.Conflict-with-YandexMaps.patch4.33 KB
new interdiff.3096776.19-20.txt1.93 KB
christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed

  • super_romeo authored 3a6a050 on 8.x-3.x 
    Issue #3096776 by super_romeo: Conflict with Yandex.Maps
christianadamski’s picture

christianadamski commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.