Meeting will happen in #d9readiness on drupal.slack.com.
| Gábor Hojtsy (he/him) |
#3088754: Update to Drupal 9 to Symfony 4.4.0 |
| Gábor Hojtsy (he/him) |
@mikelutz has been working on this |
| Gábor Hojtsy (he/him) |
looks like down to dependencies’ dependencies questions :) |
| mikelutz |
There is only one change we needed to make from the beta2 compatibility to be compatible with 4.4.0, and it was a test update. |
| greg.1.anderson |
Drush should be fine with these changes, but we'll keep an eye on it. |
| mikelutz |
Looks like @catch and @alexpott will allow committing using the explicit dependency method, so I guess I need to re-roll that with the test fix. |
| mikelutz |
Nope, I read wrong again.. |
| alexpott |
:slightly_smiling_face: I think we should add a follow-up issue to discuss this again before the beta is released |
| mikelutz |
I gave three options, @catch said he was good with 1 or 3, and alex said to use #2. So I quit until either more committers weigh in or the two there have consensus. |
| alexpott |
Fair enough |
| alexpott |
I’ll try to catch up with catch about this later or tomorrow |
| mikelutz |
Or even consensus on what to commit now, and kick the final decision to a follow-up. |
| mikelutz |
Sounds good. |
| Gábor Hojtsy (he/him) |
:thumbsup: |
| catch |
I'm pro kicking the final decision to a followup. |
| mikelutz |
@catch, Then all I need is you and @alexpott to agree on the interim solution, and I’ll roll it up. |
| alexpott |
Let’s do nothing have real dependencies and let composer get you sf5 things if that’s what it resolves to (edited) |
| mikelutz |
That probably makes the most sense if we are kicking the decision down the road. |
| mikelutz |
Wrapping up a meeting, but I’ll post it shortly. |
| Gábor Hojtsy (he/him) |
#3087685: Remove deprecated jQuery UI components and fork remaining source code into core |
| Gábor Hojtsy (he/him) |
@zrpnr and @lauriii have been working on this |
| Gábor Hojtsy (he/him) |
it was briefly RTBC by @catch, not entirely clear to me what is outstanding now, the remaining tasks list in the issue summary does not give any leads |
| zrpnr |
I can update the IS, the last remaining issues were whitespace in one of the copied source files, and opening a PR in d8githooks to check that these files have been minified correctly if there were any changes. Those are both done, and the other questions raised in this issue all have follow-ups now (edited) |
| Gábor Hojtsy (he/him) |
great, thanks — do we hope @lauriii RTBCs it, or @catch? :slightly_smiling_face: or we need more eyes on it? (edited) |
| zrpnr |
the last review was from lauri, but the whitespace change could be reviewed by anyone. He is probably the best to look at the new js written for the d8githooks PR, it is similar to the es6 check. I'm not sure who would need to actually review the d8githooks PR! |
| zrpnr |
https://github.com/alexpott/d8githooks/issues/28 |
| Gábor Hojtsy (he/him) |
@alexpott would merge it in ^^^ :slightly_smiling_face: |
| mradcliffe |
Regarding #3094468: [plan] Update core JavaScript (and CSS) dependencies prior to 9.0.0-beta1, I think that only farbtastic and jquery.cookie are concerns for 9.0.0-alpha1. The other things can be updated as the issue mentions in 9.0.0-beta1. |
| Gábor Hojtsy (he/him) |
@mradcliffe should those be broken out to their own issue then? |
| mradcliffe |
farbtastic and jquery.cookie are unmaintained/unsupported and could be security concerns. |
| mradcliffe |
We have one for jquery.cookie, and I wrote a patch :yay: |
| mradcliffe |
I don't know about farbtastic, but it's a read-only github repo. (forked for drupal's use) so if we want to ship with that, that seems fine. |
| mradcliffe |
But there would be no way to push changes upstream if something was wrong with that library. |
| Gábor Hojtsy (he/him) |
well, similar to the jQuery UI fork we have(?) |
| mradcliffe |
Yes, I think so. |
| mradcliffe |
ugh, realized I had been working on some comments about js-cookie 3.0.0 vs js-cookies 2.2.1 and I never finished and closed the browser tab they were in a long time ago :disappointed: |
| mradcliffe |
I don't know if these are truly alpha blockers, but still would block beta like the rest of the javascript dependencies. |
| mradcliffe |
@Gábor Hojtsy (he/him) |
| Gábor Hojtsy (he/him) |
@mradcliffe my understanding was that these are considered beta blocker as per the issue, but if there are disruptive updates, those should be discussed with release managers :slightly_smiling_face: |
| mradcliffe |
I guess with a bc layer it wouldn't be disruptive. |
| Gábor Hojtsy (he/him) |
I should have a META issue to track all of them at once place really |
| Gábor Hojtsy (he/him) |
give me a couple minutes :smile: |
| Gábor Hojtsy (he/him) |
Issues gathered now in #3096678: [META] Missing deprecation testing coverage |
| Gábor Hojtsy (he/him) |
@mglaman had proof of concept code that hardcoded core constants, I think that would still be better than nothing, if someone can help salvage that and get it in :slightly_smiling_face: |
| Gábor Hojtsy (he/him) |
I think we hoped that we find people interested in filling these gaps by this point :slightly_smiling_face: |
| Gábor Hojtsy (he/him) |
the more visible we make the reports, the more pressing it is that there are some sizable holes in the reporting |
| mradcliffe |
I don't think we can use phpstan to test non-php files like JavaScript. There might be an existing eslint plugin. eslint can output junit. |
| Gábor Hojtsy (he/him) |
@mradcliffe yeah the idea was that drupal-check could merge the outputs and the result would be used altogether |
| mradcliffe |
Here's the issue on github - https://github.com/mglaman/drupal-check/issues/29 |
| Gábor Hojtsy (he/him) |
yup :slightly_smiling_face: |
| Gábor Hojtsy (he/him) |
I opened the upgrade status counterpart but that is not the place to fix it in a first party way :slightly_smiling_face: |
Comments
Comment #2
gábor hojtsyComment #4
mikelutzComment #6
mikelutzComment #8
mikelutzComment #10
mikelutzComment #12
mikelutzComment #14
mikelutzComment #16
mikelutzComment #18
mikelutzComment #19
mikelutzComment #20
gábor hojtsyFix title and relationships given Nov 25 meeting log posted :) Thanks @mikelutz!
Comment #21
mikelutz