When we migrate a wysiwyg content whose contains a file, there is some problems :

  1. If the source view_mode does not exist in the D8 version, we have an error while displaying the file (data-entity-embed-display) : to solve this we can allow to use a mapping array between the old and the new view mode in the migration file
  2. If the source file fid was not preserved during the migration we need to update it into the wysiwyg (data-entity-id) : for this we can allow to use a migration id array into the migration file so we can use the migration lookup system for this
  3. The pattern /file/{fid}/download?token={token} needs also to be updated with new fid and token : we can also use the migration lookup system as well as the getDownloadToken() method

Example of use :

process:
  field_body:
    -
      plugin: media_wysiwyg_filter
      view_mode_matching:
        default: full
      media_migrations:
        - upgrade_d7_file_entity_archive
        - upgrade_d7_file_entity_image
        - upgrade_d7_file_entity_publication
      file_migrations:
        - upgrade_d7_file
      source: field_user_texte
CommentFileSizeAuthor
#12 interdiff_9_12.txt505 bytesnixou
#12 media-migration-mapping-datas-image-wysiwyg-3096596-12-D8.patch3.95 KBnixou
#9 interdiff_8_9.txt3.69 KBnixou
#9 media-migration-mapping-datas-image-wysiwyg-3096596-9-D8.patch3.95 KBnixou
#8 interdiff_6_8.txt933 bytesnixou
#8 media-migration-mapping-datas-image-wysiwyg-3096596-8-D8.patch3.66 KBnixou
#6 interdiff_2_6.txt4.58 KBnixou
#6 media-migration-mapping-datas-image-wysiwyg-3096596-6-D8.patch3.72 KBnixou
#4 interdiff_2_4.txt4.77 KBnixou
#4 media-migration-mapping-datas-image-wysiwyg-3096596-4-D8.patch3.9 KBnixou
#2 media-migration-mapping-datas-image-wysiwyg-3096596-2-D8.patch1.71 KBcaco_d25

Comments

caco_d25 created an issue. See original summary.

caco_d25’s picture

caco_d25 commented
StatusFileSize
new media-migration-mapping-datas-image-wysiwyg-3096596-2-D8.patch1.71 KB

Configuration file example : 

process:
  field_title:
    -
      plugin: get
      source: field_title
  field_body:
    -
      plugin: media_wysiwyg_filter
      source: field_body
      matching:
        - default: full
        - teaser: accroche
      migrations:
        - upgrade_d7_file_entity_image
        - upgrade_d7_file_entity_local_video
destination:
  plugin: 'entity_reference_revisions:paragraph'
  default_bundle: multiblock_image_wysiwyg
migration_dependencies:
  optional: {  }
  required:
    - migrate_plus.migration.upgrade_d7_file_entity_image
    - migrate_plus.migration.upgrade_d7_file_entity_local_video
caco_d25’s picture

caco_d25 commented
Status: Active » Needs review
nixou’s picture

nixou commented
StatusFileSize
new media-migration-mapping-datas-image-wysiwyg-3096596-4-D8.patch3.9 KB
new interdiff_2_4.txt4.77 KB

This is working for me.

I made some cleaning and add a new feature to update pattern "/file/{fid}/download?token={token}" with the new fid and token.

nixou’s picture

nixou commented
Title: Mapping of datas for image in wysiwyg during migration D7 to D8 » Mapping of fid, view mode and download token for file in wysiwyg during migration
Issue summary: View changes
nixou’s picture

nixou commented
StatusFileSize
new media-migration-mapping-datas-image-wysiwyg-3096596-6-D8.patch3.72 KB
new interdiff_2_6.txt4.58 KB

Oops, the patch do not apply, I created a new one that apply correctly.

nixou’s picture

nixou commented
nixou’s picture

nixou commented
StatusFileSize
new media-migration-mapping-datas-image-wysiwyg-3096596-8-D8.patch3.66 KB
new interdiff_6_8.txt933 bytes

During my tests I got an error in case the file referenced by the wysiwyg no longer exists on the source site.

Indeed the file does not exist anymore, it is not migrated and the File::load does not work.

I added a condition to check that the file is loaded before trying to retrieve its new token.

nixou’s picture

nixou commented
StatusFileSize
new media-migration-mapping-datas-image-wysiwyg-3096596-9-D8.patch3.95 KB
new interdiff_8_9.txt3.69 KB

I didn't pay attention but for the two features "embed update" and "download link update" in wysiwyg, we don't rely on the same migrations.

In the first case we have to use the media migration since we want to indicate a media identifier.
And in the second case we have to base ourselves on the migration of the files since we want to indicate a file identifier.

I have updated the code in this sense and to allow two sets of migration files.

nixou’s picture

nixou commented
nixou’s picture

nixou commented
Issue summary: View changes
nixou’s picture

nixou commented
StatusFileSize
new media-migration-mapping-datas-image-wysiwyg-3096596-12-D8.patch3.95 KB
new interdiff_9_12.txt505 bytes

I changed the function from private to protected to allow to extend easily the plugin.

steinmb’s picture

steinmb commented
Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
Assigned: caco_d25 » Unassigned

If you want other to review it. It probably should not be assign to you. Also make sure the patch apply cleanly against dev.

mortona2k’s picture

mortona2k commented
Status: Needs review » Reviewed & tested by the community

I have been working on a migration with this patch and it seems to work. This adds some very important features for these migrations.

  • juampynr committed 8a6592c on 8.x-1.x authored by Nixou 
    Issue #3096596 by Nixou, caco_d25: Mapping of fid, view mode and...
juampynr’s picture

juampynr commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

  • huzooka authored 863bc54 on 8.x-1.x 
    Issue #3128540 by huzooka: Follow up for #3096596: MediaWysiwygFilter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.