poll-results.html.twig documents 'vote' as the current user's vote, but is always empty

It is also called in template_preprocess_poll_meter() now, can we update that to avoid calling the results multiple times? I only just now realized that the other one does call it for each option, which is not optimal :-/ Alternatively, there's a separate issue to add static caching to that method, that would be fine too then.

+++ b/src/Form/PollViewForm.php
@@ -271,7 +275,7 @@ class PollViewForm extends FormBase implements BaseFormIdInterface {
+      '#vote' => $user_vote['chid'] ?? NULL,

Think we need to wait for 8.6 to go unsupported before we can ??

1. +++ b/tests/src/Kernel/PollKernelTestBase.php
   @@ -0,0 +1,75 @@
   +   * @param int $choice_count
   +   *   (optional) The number of choices to generate. Defaults to 7.
   +   *
   +   * @return \Drupal\poll\PollInterface
   +   *   A poll.
   +   */
   +  public function createPoll($choice_count = 7) {
   +    /** @var \Drupal\poll\PollInterface $poll */
   +    $poll = Poll::create([
   

   is 7 the same as the functional test? seems a bit overkill especially since we're not ever going to bother with testing how it looks in the UI or so, so maybe default to 2 or 3 options?

2. +++ b/tests/src/Kernel/PollKernelTestBase.php
   @@ -0,0 +1,75 @@
   +   * Saves a vote for a given poll.
   +   */
   +  public function saveVote(PollInterface $poll, $choice_id) {
   +    $options = [];
   +    $options['chid'] = $choice_id;
   +    $options['uid'] = \Drupal::currentUser()->id();
   +    $options['pid'] = $poll->id();
   +    $options['hostname'] = \Drupal::request()->getClientIp();
   +    $options['timestamp'] = \Drupal::time()->getRequestTime();
   +    /** @var \Drupal\poll\PollVoteStorage $vote_storage */
   +    $vote_storage = \Drupal::service('poll_vote.storage');
   +    $vote_storage->saveVote($options);
   +  }
   +
   

   relying on the current user in a kernel test is a bit strange, can't we just pass in a user id? then we can skip the current user set up in the test.

3. +++ b/tests/src/Kernel/PollResultsTest.php
   @@ -0,0 +1,43 @@
   +
   +    $choice_id = $poll->get('choice')->first()->getValue();
   +    $this->saveVote($poll, $choice_id['target_id']);
   

   $poll->get('choice')->target_id is the same and short enough to be inlined with the saveVote() call IMHO.

   Relying on __get() isn't great, but on the field level, there is no good alternative right now, we specifically optimized that, compared to getValue(), which is awkward to use and get('target_id')->getValue(), which has to create another object.

All feedback addressed, looks good!

Yes, looks good. I realized in the other issue that poll vote storage does rely on the current user, so setting it up like that in general makes sense, but it defaults to 0, so we don't need it for that.

Committed.