The module has grown from several different approaches to find the best implementation. Finally it should be checked for refactorings and tests should be added to proof correct results.

The code still contains some TODOs to check.

  1. Understand what the module does
  2. Write tests for that
  3. Clean up code and ensure nothing breaks :)

Issue fork rabbit_hole_href-3095839

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.0.x-dev
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

@Grevil perhaps you could add some basic tests sooner or later...

grevil’s picture

grevil commented

Will do!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Refactor & write tests » Refactor code & write tests
grevil’s picture

grevil commented

I fixed the coding standards and added basic installation tests.

Note, two things:
- Drupal Coding Standards could not get completely fixed, since there is a bunch of commented out code, we don't want to remove. This Code has to be resolved first, before we can completely fix the coding standards.
- The Tests currently fail because of some weird reason.

Undefined array key "label"

This gets thrown in a core file "web/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/EntityDeriver.php" line 108.
I am not quite sure what the exact problem is here...
I first thought it would be the class notation of "PageRedirectHref" but I am not confident enough about this assumption.

grevil’s picture

grevil commented

Fixed module breaking bug.

grevil’s picture

grevil commented

For the remaining problems, I will create appropriate issues.

grevil’s picture

grevil commented
Priority: Minor » Critical
Status: Active » Needs review

Setting this to critical, as the module backend does not work without this patch. Please review and commit ASAP!

Grevil opened merge request !1

grevil’s picture

grevil commented
Related issues: +#3207307: Call to a member function loadBehaviorSettingsAsConfig() on null

  • Grevil committed db3407b on 2.0.x 
    Issue #3095839: Refactor code & write tests
grevil’s picture

grevil commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.