Problem/Motivation

We should add defaultTheme where it will be required in tests extending BrowserTestBase.

Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/2352949, which includes recommendations on which theme to use.

See https://www.drupal.org/node/3083055
and https://www.drupal.org/project/drupal/issues/3082655

Proposed resolution

Add the defaultTheme property to tests that extend BrowserTestBase, where appropriate or another theme where appropriate, based on https://www.drupal.org/node/3083055

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3095617-7.patch444 bytesakashkumar07
#5 add_defaultTheme_in_tests_extending_browserTestBase-3095617-4.patch853 bytesgnanagowthaman sankar
#5 interdiff_2-4.txt394 bytesgnanagowthaman sankar
#2 3095617-2.patch880 bytesrpayanm

Comments

oknate created an issue. See original summary.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3095617-2.patch880 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/tests/src/Kernel/CropUnitTestBase.php
@@ -59,6 +59,11 @@ abstract class CropUnitTestBase extends KernelTestBase {
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
   /**

kernel tests don't need this.

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented
Status: Needs work » Needs review

Hi @Berdir,

As you mentioned I made the following changes. Please review and let me know for any changes.

Thanks & Regards,
Gnanagowthaman sankar

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented
StatusFileSize
new interdiff_2-4.txt394 bytes
new add_defaultTheme_in_tests_extending_browserTestBase-3095617-4.patch853 bytes

Patch,

Thanks & Regards,
Gnanagowthaman sankar

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

There's still a left-over spaces change now in the kernel test.

akashkumar07’s picture

akashkumar07 commented
Status: Needs work » Needs review
StatusFileSize
new 3095617-7.patch444 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Thanks.

  • phenaproxima committed e78bd55 on 8.x-2.x 
    Issue #3095617 by Gnanagowthaman sankar, AkashkumarOSL, rpayanm, Berdir...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.