Closed (fixed)
Project:
Commerce Open Payment Platform
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Nov 2019 at 12:07 UTC
Updated:
16 Jun 2020 at 16:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
agoradesign commentedComment #4
agoradesign commentedimprove variable name
Comment #5
agoradesign commentedchanged the shipped Twig template a little bit
Comment #7
agoradesign commentedcommitted.. please re-open, if there's any problem @rochate
Comment #8
jrochate commentedIt looks (and works) good.
Some shop providers print the ref numbers using space as thousand separator, but some don't (to make it easier for a copy&paste).
I think that can be left to the theme side, by replacing twig template and use |number_format for that.
Like this:
<p>{{ 'MB reference'|t }}: <strong>{{ pmt_ref|number_format(0,'',' ') }}</strong></p>Comment #10
agoradesign commentedgood addition! thanks :)
Comment #12
jrochate commentedHi.
There is a problem with my own proposed twig on #8:
- the references started by ZERO become incomplete, because the nine chars are valid.
Here is a new twig that solve this by not converting to number and splitting the string in 3.
Comment #13
agoradesign commentedplease change status next time - or better create a new issue. because otherwise I'd just oversee or forget that issue... now it's visible in the queue again
Comment #15
agoradesign commented