I believe, this module should be part of larger Layout Ecosystem. Currently I see this in other section in "admin/modules"

CommentFileSizeAuthor
#8 3095261-8.patch437 bytesjohnwebdev
#7 3095261-layout-builder-ecosystem-7.patch0 bytesmark_fullmer
#5 3059333-print-style-behavior-10.patch9.17 KBmark_fullmer

Comments

vaibhavjain created an issue. See original summary.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Based on the reference to "admin/modules", I'm concluding the suggestion is to change package: 'Custom' in the .info.yml file to something like 'Layout' or 'Layout Builder'

johnwebdev’s picture

johnwebdev commented

Yeah, using Custom is not correct. I am also suggesting that we use Layout Builder, similar to Layout Builder UX and Layout Builder Everywhere does.

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented

Thanks @mark_fullmer you got that right. I should have been more elaborative in my words.
Here is the link to Layout Builder Ecosystem. https://www.drupal.org/project/layout_builder/ecosystem
Hope that helps !!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Needs review
StatusFileSize
new 3059333-print-style-behavior-10.patch9.17 KB

Agreed on "Layout Builder". Patch attached formal review.

I don't believe this will adversely affect any existing sites using Layout Builder Modal, as the 'package' value is display/categorization only.

johnwebdev’s picture

johnwebdev commented
Status: Needs review » Needs work

I think you uploaded the wrong patch Mark!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs work » Needs review
StatusFileSize
new 3095261-layout-builder-ecosystem-7.patch0 bytes

Ha! Better to upload the wrong patch than to commit it, I suppose. Here's the right one.

johnwebdev’s picture

johnwebdev commented
StatusFileSize
new 3095261-8.patch437 bytes
johnwebdev’s picture

johnwebdev commented
Status: Needs review » Reviewed & tested by the community

RTBC #8. Feel free to commit Mark. :)

  • mark_fullmer committed 7c4364b on 8.x-1.x 
    Issue #3095261 by mark_fullmer, johndevman, vaibhavjain: Indicate Layout...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Reviewed & tested by the community » Fixed

Thanks, all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.