The changes in #2572119: Update actions & conditions to use doExecute / doEvaluate were never applied to actions defined by test modules.

This was noted in #2572119-8: Update actions & conditions to use doExecute / doEvaluate at the time, but dismissed by #2572119-11: Update actions & conditions to use doExecute / doEvaluate. I do not agree with the objections in that latter post. In order for tests to be effective, we must program test actions the same way we would program real actions, otherwise we don't end up testing the way real code works.

This patch applies the changes to the three actions defined in our test modules.

CommentFileSizeAuthor
do-execute-in-test-actions.patch2.47 KBtr

Comments

TR created an issue. See original summary.

  • TR committed fc1b03a on 8.x-3.x
    Issue #3095036 by TR: Actions in test modules need updating
    
tr’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.