The session limit doesn't work for admin user (uid: 1), where for the other users it's OK

CommentFileSizeAuthor
#8 session_limit-doesnt-work-for-admins-3094634-8.patch2.71 KBsteven.wichers
#6 Screen Shot 2019-12-09 at 12.44.49 PM.png102.07 KBsnehalgaikwad
#4 Session_limit_dosent_work-3094634-4.patch3.38 KBhardik_patel_12
#2 session_limit_in_admin_user-3094634-2.patch637 bytesdimitriskr

Comments

dimitriskr created an issue. See original summary.

dimitriskr’s picture

dimitriskr commented
StatusFileSize
new session_limit_in_admin_user-3094634-2.patch637 bytes

Here is a patch in case somebody wants that. It's working on my website

I understand that some admins may not want to have a session timeout but I believe especially on the admin user this should exist.

hardik_patel_12’s picture

hardik_patel_12 commented
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new Session_limit_dosent_work-3094634-4.patch3.38 KB

Instead of hardcoded value for admin in code , i have given option in configuration that if we want add admin also under session limit or not. Based on user selection admin will work with session limit module.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
snehalgaikwad’s picture

snehalgaikwad commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-12-09 at 12.44.49 PM.png102.07 KB

I have tested this patch and working for admin as expected.

hardik_patel_12’s picture

hardik_patel_12 commented

In this patch i have also covered issue of "https://www.drupal.org/project/session_limit/issues/3098591"

steven.wichers’s picture

steven.wichers commented
StatusFileSize
new session_limit-doesnt-work-for-admins-3094634-8.patch2.71 KB

Rerolled to remove unrelated bugfix from the patch.

  • suzymasri committed 9a4d940 on 2.x 
    Issue #3094634 by Hardik_Patel_12, dimitriskr, steven.wichers,...
suzymasri’s picture

suzymasri
Location Greece
commented
Status: Reviewed & tested by the community » Fixed

Released in 2.0.0-beta1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.