Currently _all_ exceptions show up as NoticedError in error analytics. This mans you kinda have to parse through the messages and hope things align to get useful trends or meaning. But with a small change to newrelic and a small change to core this doesn't have to be the case. Event better, we can support this today without much hassle and support it for contrib and custom code until accepts these changes:
https://www.drupal.org/node/2932520
The key benefits are better grouping:
And real stack stack traces, not the trace of the error handler:
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3094508-3.interdiff.txt | 2.16 KB | neclimdul |
| #3 | 3094508-3.patch | 3.79 KB | neclimdul |
| 2019-11-14_14-22.png | 72.34 KB | neclimdul | |
| 2019-11-14_14-18.png | 46.19 KB | neclimdul |
Comments
Comment #2
andypostLooks great to go
Comment #3
neclimdulBah, didn't think about tests. This fixes the old tests since they assert the exact method call and the new null argument being sent doesn't match.
Also adds a test because... why not?
Comment #4
andypostGreat
Comment #5
nterbogt commentedAre we happy to wait on this for a 1.1 release? I would like to get through the Security Support process, and we can't do that without a release with no issues sitting there for a couple of weeks.
Comment #6
nterbogt commentedDo you also need to update the NullAdapter to match the interface definition?
Comment #7
Chris CharltonComment #9
nterbogt commented