Read more button and add new comment buttons are styled now.

CommentFileSizeAuthor
#7 Screenshot (11).png275.87 KBtushar_sachdeva
#7 readmore_comment-3094415-6.patch390 bytestushar_sachdeva
#5 capture.png17.45 KBtushar_sachdeva
#5 readmore_addcomment-3094415-5.patch779 bytestushar_sachdeva
#4 warnings.png17.97 KBPremanshu
#2 ReadMore-AddNewComment.png3.51 KBgakshii
#2 3094415-2.patch409 bytesgakshii
Screenshot 2019-11-14 at 3.56.13 PM.png17.06 KBkunal_kapoor

Comments

kunalkapoor created an issue. See original summary.

gakshii’s picture

gakshii commented
Title: Read more button and add new comment buttons don’t have any styling » Read more button and add new comment have proper style.
Status: Active » Needs review
Issue tags: +button, +readmore
StatusFileSize
new 3094415-2.patch409 bytes
new ReadMore-AddNewComment.png3.51 KB
Premanshu’s picture

Premanshu commented
Title: Read more button and add new comment have proper style. » Read more button and add new comment do not have proper style.
Premanshu’s picture

Premanshu commented
Priority: Major » Normal
Status: Needs review » Needs work
Issue tags: +Novice
StatusFileSize
new warnings.png17.97 KB

@gakshii The patch applies and provides styling for the "Read More" and "Add New Comment" Button.

Things to note:

1. Do not leave trailing whitespace as it generates warning.
2. Please name your patches according to the standards using this command :

git diff > [description]-[issue-number]-[comment-number].patch

Please provide a new patch while keeping the above things in mind.

tushar_sachdeva’s picture

tushar_sachdeva commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new readmore_addcomment-3094415-5.patch779 bytes
new capture.png17.45 KB

I have provided the correct patch please use it.

djsagar’s picture

djsagar commented
Status: Needs review » Needs work

Hi,

Patch you are created is not matching as design.

tushar_sachdeva’s picture

tushar_sachdeva commented
Status: Needs work » Needs review
StatusFileSize
new readmore_comment-3094415-6.patch390 bytes
new Screenshot (11).png275.87 KB

Apply this patch for the same.

djsagar’s picture

djsagar commented
Status: Needs review » Reviewed & tested by the community

  • tushar_sachdeva authored 6b392c9 on 8.x-1.x 
    Issue #3094415 by tushar_sachdeva, gakshii, Premanshu, kunalkapoor: Read...
gaurav.kapoor’s picture

gaurav.kapoor commented

Thanks for working on this.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.