CommentFileSizeAuthor
#8 coding_standards-3094157-8.patch89.3 KBkunal_kapoor
#6 coding_standards-3094157-6.patch114.27 KBkunal_kapoor
#2 image_width-3094157-2.patch398 byteskunal_kapoor
#2 Screen Shot 2019-11-13 at 6.59.50 PM.png890.61 KBkunal_kapoor

Comments

kunalkapoor created an issue. See original summary.

kunal_kapoor’s picture

kunal_kapoor commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2019-11-13 at 6.59.50 PM.png890.61 KB
new image_width-3094157-2.patch398 bytes

I have provided a for this issue, Please let me know if it works

kunal_kapoor’s picture

kunal_kapoor commented
gaurav.kapoor’s picture

gaurav.kapoor commented

Hi,

1. The patch doesn't apply.
2. Please fix coding standards.
3. Use development branch instead of alpha release.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work
kunal_kapoor’s picture

kunal_kapoor commented
Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new coding_standards-3094157-6.patch114.27 KB

I have provided another patch for this please let me know if it works.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work

Please do not fix all the coding standards in this issue. Fix only for the patch which you are providing.

kunal_kapoor’s picture

kunal_kapoor commented
Status: Needs work » Needs review
StatusFileSize
new coding_standards-3094157-8.patch89.3 KB

Please try this patch and let me know if it works

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.