Closed (fixed)
Project:
Webform Validation
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
12 Nov 2019 at 16:45 UTC
Updated:
17 Jan 2020 at 23:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
liam morlandIt would be great to have that as a patch.
Comment #3
larynNo problem -- patch attached. See what you think. I'm also attaching before and after screenshots. (Before: error appears after submission; After: countdown/validation happens live before submission).
This MaxLength integration is based on work by [Hal Eagar](https://www.drupal.org/node/1459650#comment-9011799), with enhancements from [Allen Shaw](https://github.com/twomice).
Comment #4
liam morlandThanks for the patch.
Please check coding standards. I think $maxlength_desc should be empty when maxlength is not installed. webform_validation_get_node_rules() always returns an array so the
if ($rules)is not needed.Comment #5
larynThanks for reviewing! How does this look?
Comment #6
larynComment #7
liam morlandThanks for the patch.
There are still coding standards issues. Please install code sniffer to check these.
Comment #8
larynThird time's the charm? (Thanks for holding my hand a bit... I'm learning!)
There are a few errors/warnings on Code Sniffer yet but they are unrelated to anything I've added, so I didn't change them here.
Comment #9
liam morlandComment #11
liam morlandThanks!