While fixing tests for another issue i saw that removeResourceTypeFromDocument was called with the wrong amount of arguments in `Drupal\Tests\jsonapi\Functional\ResourceTestBase` line 1881.

This patch fixes that issue.

CommentFileSizeAuthor
#2 3093752-1.patch1.02 KBbbrala

Comments

bbrala created an issue. See original summary.

bbrala’s picture

bbrala
Location Netherlands
commented
StatusFileSize
new 3093752-1.patch1.02 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: Bug report » Task

Not sure if this counts as a bugfix as in fixing a test, but since a bugfix kind of requires a failing test, I'd go with a task :)

bbrala’s picture

bbrala
Location Netherlands
commented

Fair point, thanks :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Call in jsonapi tests uses wrong argument count » Call to JSON:API test helper method passes an argument that no longer exists
Priority: Normal » Minor
Issue tags: +API-First Initiative

Woah, that's one lovely detail that you found there!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Checked and confirmed.

bbrala’s picture

bbrala
Location Netherlands
commented

Awesome, thanks :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed 0ef5863112 to 9.0.x and 6eafc1f35c to 8.9.x. Thanks!

As this is in a test I will backport to 8.8.x once the freeze is over.

  • alexpott committed 0ef5863 on 9.0.x 
    Issue #3093752 by bbrala, Wim Leers: Call to JSON:API test helper method...

  • alexpott committed 6eafc1f on 8.9.x 
    Issue #3093752 by bbrala, Wim Leers: Call to JSON:API test helper method...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

  • alexpott committed faceb33 on 8.8.x 
    Issue #3093752 by bbrala, Wim Leers: Call to JSON:API test helper method...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.