Remove all deprecated code in core file system e.g. under core/lib/Drupal/Core/File and related tests.

CommentFileSizeAuthor
#9 3093564-9.drupal.Remove-all-deprecated-code-in-core-File-system.patch7.12 KBlongwave
#6 After apply patch.png146.12 KBvinodhini.e
#4 deprecated_filesystem-3093564-4.patch19.13 KBdinesh18
#2 deprecated_filesystem-3093564-2.patch3.91 KBdinesh18

Comments

kim.pepper created an issue. See original summary.

dinesh18’s picture

dinesh18 commented
Status: Active » Needs review
StatusFileSize
new deprecated_filesystem-3093564-2.patch3.91 KB

Here is the patch which removes the deprecated code. Kindly review

Status: Needs review » Needs work

The last submitted patch, 2: deprecated_filesystem-3093564-2.patch, failed testing. View results

dinesh18’s picture

dinesh18 commented
StatusFileSize
new deprecated_filesystem-3093564-4.patch19.13 KB

Here is the updated patch. It should pass.

dinesh18’s picture

dinesh18 commented
Status: Needs work » Needs review
vinodhini.e’s picture

vinodhini.e commented
StatusFileSize
new After apply patch.png146.12 KB

@Dinesh18, I have applied a patch and tested using drupal check module. I am getting two errors, please refer below image.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ /dev/null
@@ -1,270 +0,0 @@
-
-/**
- * Tests deprecations in file.inc.
- *
- * @group File
- * @group legacy
- */
-class FileSystemDeprecationTest extends KernelTestBase {
-
-  /**

this is actually more about file.inc removals, which is #3062757: Remove deprecated legacy include files from Drupal 9 , so we likely need to wait on that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

That issue landed, so we can reroll this.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3093564-9.drupal.Remove-all-deprecated-code-in-core-File-system.patch7.12 KB

Rerolled.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Pretty straight-forward now, can't see anything else in the File component.

#6: This is not the same as deprecation *usage* removal patches. This removes the actual deprecated code and drupal-check is not really relevant for this. To test patches like this for Drupal 9, you need to instead search for @deprecated and @trigger_error. The things you reported are related to new symfony deprecations and not something to be fixed here.

  • catch committed 8d6d914 on 9.0.x 
    Issue #3093564 by Dinesh18, longwave, Vinodhini.E, Berdir, kim.pepper:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Fixed on commit:


PHPCS: core/lib/Drupal/Core/File/FileSystemInterface.php passed
it
FILE: ...ests/Drupal/KernelTests/Core/File/FileSystemRequirementsTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Committed 8d6d914 and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.