CommentFileSizeAuthor
#19 3093563-19.patch40.26 KBlongwave
#18 3093563-10-17.interdiff.patch12.75 KBnigelcunningham
#18 3093563-17.patch57.36 KBnigelcunningham
#12 3093563-12.patch70.43 KBnigelcunningham
#10 interdiff-7-10.txt1.75 KBlongwave
#10 3093563-10.patch70.37 KBlongwave
#7 3093563-7.patch68.93 KBlongwave
#6 3093563-6-interdiff.txt20.88 KBkim.pepper
#6 3093563-6.patch52.6 KBkim.pepper
#5 deprecated_file_module-3093563-5.patch56 KBdinesh18
#3 deprecated_file_module-3093563-3.patch31.73 KBdinesh18
#2 deprecated_file_module-3093563-2.patch31.91 KBdinesh18

Comments

kim.pepper created an issue. See original summary.

dinesh18’s picture

dinesh18 commented
Status: Active » Needs review
StatusFileSize
new deprecated_file_module-3093563-2.patch31.91 KB

Here is the patch which removed the deprecated code from File module. Here is the initial patch. Still some fixes needs to be done.

dinesh18’s picture

dinesh18 commented
StatusFileSize
new deprecated_file_module-3093563-3.patch31.73 KB

Adding the patch again with fixes.

Status: Needs review » Needs work

The last submitted patch, 3: deprecated_file_module-3093563-3.patch, failed testing. View results

dinesh18’s picture

dinesh18 commented
Status: Needs work » Needs review
StatusFileSize
new deprecated_file_module-3093563-5.patch56 KB

Here is the updated patch. It should pass

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
StatusFileSize
new 3093563-6.patch52.6 KB
new 3093563-6-interdiff.txt20.88 KB

Here's an updated patch from #3 that removes the legacy tests.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3093563-7.patch68.93 KB

#6 needed reroll (so no interdiff) and there were still quite a few deprecations remaining, this should cover them all.

Status: Needs review » Needs work

The last submitted patch, 7: 3093563-7.patch, failed testing. View results

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Issue tags: +DrupalSouth 2019
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3093563-10.patch70.37 KB
new interdiff-7-10.txt1.75 KB
nigelcunningham’s picture

nigelcunningham commented

I'm reviewing and checking this patch at DS 2019 (just flagging this to avoid duplicating effort with someone else).

nigelcunningham’s picture

nigelcunningham commented
StatusFileSize
new 3093563-12.patch70.43 KB

One hunk is now rejected (as at 0a68ef68). Update the patch to apply cleanly again.

My bad. I was on the wrong branch; please ignore the patch in this comment.

The previous patch can be RTBC.

nigelcunningham’s picture

nigelcunningham commented
Status: Needs review » Reviewed & tested by the community

(Applies to #10)

andypost’s picture

andypost
he/him
Primary language Russian
commented
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Ran drupal-check on #10 and found no deprecations.

RTBC +1

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +needs re-roll

Needs a re-roll.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
Issue tags: -needs re-roll
StatusFileSize
new 3093563-17.patch57.3 KB
nigelcunningham’s picture

nigelcunningham commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3093563-17.patch57.36 KB
new 3093563-10-17.interdiff.patch12.75 KB

Haha. I was just doing it too, and came up with the same patch so I'll put it straight to RTBC.

.... oops. The files I'd uploaded came along for the ride. Humble apologies. Just as well it's the same content.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3093563-19.patch40.26 KB

@NigelCunningham: no worries :)

Reroll again following #3088480: Remove the "cckfield" plugin type from the migration system

The last submitted patch, 18: 3093563-10-17.interdiff.patch, failed testing. View results

  • catch committed e6fd7b2 on 9.0.x 
    Issue #3093563 by longwave, NigelCunningham, Dinesh18, kim.pepper:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Since the re-roll was just removing hunks, treating this as RTBC and committed/pushed to 9.0.x, thanks!

andypost’s picture

andypost
he/him
Primary language Russian
commented

I bet this should be included here, but filed follow-up #3097379: Remove deprecated markup from file module for D9

nigelcunningham’s picture

nigelcunningham commented

Add Technocrat credit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.