In the course of writing some help topics, I noticed a couple of minor things to improve on the already-committed block topics.
Patch coming shortly.

CommentFileSizeAuthor
#5 3093089-5.patch1.93 KBjhodgdon
#2 3093089.patch1.93 KBjhodgdon

Comments

jhodgdon created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3093089.patch1.93 KB
amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented

1. The anchor tag on line 18 of block.place.html.twig is unclosed. (It's closed with an open tag.)

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Status: Needs review » Needs work
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
StatusFileSize
new 3093089-5.patch1.93 KB

Doh. Obviously our tests are not catching this, which is unfortunate. We will need to file a follow-up issue, because I thought we were checking for malformed HTML (there was even a test for the test). Anyway, here's a new patch. Thanks for your careful review, as always!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Status: Needs review » Reviewed & tested by the community

Assuming the tests pass, setting this to RTBC. Thanks for the quick fix and for the improvements to these topics!

dinesh18’s picture

dinesh18 commented

#5 patch looks good to me. +1 to RTBC

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

Patch looks good to me.
+1 to RTBC

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Related issues: +#3090257: Add additional tests for help topic syntax

Regarding the follow-up issue mentioned in #5, checking for correct HTML syntax is already on this related issue, which is part of the Roadmap already.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed cf1cb8ab10 to 9.0.x and c696aa1cb0 to 8.9.x. Thanks!

Will backport to 8.8.x once the freeze is over.

  • alexpott committed cf1cb8a on 9.0.x 
    Issue #3093089 by jhodgdon, Amber Himes Matz: Minor improvements to...

  • alexpott committed c696aa1 on 8.9.x 
    Issue #3093089 by jhodgdon, Amber Himes Matz: Minor improvements to...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

  • alexpott committed 6aca314 on 8.8.x 
    Issue #3093089 by jhodgdon, Amber Himes Matz: Minor improvements to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.