Problem/Motivation

In #3062757-22: Remove deprecated legacy include files from Drupal 9 (2) discovered that comment references to non-existing method

Proposed resolution

Clean-up comment

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

Status: Active » Needs review
FileSize
553 bytes
andypost’s picture

Title: Fix wrong reference in testEscapeString from afeMarkupTest.php » Fix wrong reference to testEscapeString() from SafeMarkupTest.php
Berdir’s picture

Status: Needs review » Needs work

The method is called testHtmlEscapedText(), so it doesn't reference a removed method, just the wrong name..

andypost’s picture

Status: Needs work » Needs review
FileSize
694 bytes
717 bytes

@Berdir thank you, missed the name, btw in 9.0 one of them should be removed as test marked as legacy

Anyway here's a proper patch

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Ok, then I'd say lets commit this to 8.8/8.9 and the other issue can remove it in 9.0.x, and also doesn't need to be blocked on this anymore?

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed d507e67789 to 8.9.x and d29f4f107a to 8.8.x. Thanks!

Backported to 8.8.x since this is a test-only documentation and not committed to 9.0.x because this test will be removed there.

  • alexpott committed d507e67 on 8.9.x
    Issue #3092791 by andypost, Berdir: Fix wrong reference to...

  • alexpott committed d29f4f1 on 8.8.x
    Issue #3092791 by andypost, Berdir: Fix wrong reference to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.