php drupal-check.phar modules/contrib/duration_field/
 33/33 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------ 
  Line   duration_field.install                                      
 ------ ------------------------------------------------------------ 
  21     Call to deprecated method entityManager() of class Drupal.  
  90     Call to deprecated method entityManager() of class Drupal.  
  129    Call to deprecated function db_change_field().              
  131    Call to deprecated function db_add_field().                 
  133    Call to deprecated function db_change_field().              
  135    Call to deprecated function db_add_field().                 
 ------ ------------------------------------------------------------
CommentFileSizeAuthor
#7 3091695.4_7.interdiff.txt535 bytesdww
#7 3091695-7.patch4.16 KBdww
#4 3091695-4.patch3.52 KBankush_03
#2 deprecated-3091695-2.patch3.19 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3091695-2.patch3.19 KB

Here's the patch, please review.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Can we also add the D9 core_version_requirement as per https://www.drupal.org/node/3070687? Even if it isn't 100% ready and there's a dev release, we can keep making progress on https://www.drupal.org/project/datetime_extras/issues/3125514. Until then, we're 100% blocked due to composer dependency issues.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Needs work » Needs review
Issue tags: +DIACWApril2020
StatusFileSize
new 3091695-4.patch3.52 KB

Adding updated patch !

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community

The patch looks good to me.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Needs work

I have a local 9.0.x core install with duration_field installed. With this patch applied, all the Unit tests pass, but all the Functional tests are failing locally with this:

1) Drupal\Tests\duration_field\Functional\DurationFieldFunctionalTest::testHumanReadableFormatter
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

So at the very least, we need that on all the functional test classes.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Needs review
StatusFileSize
new 3091695-7.patch4.16 KB
new 3091695.4_7.interdiff.txt535 bytes

Like so. With this, the existing Functional tests are now passing with 9.0.x core. upgrade_status reports no further errors. So probably this is now RTBC, but it'd be nice for someone else to review it, too.

Thanks,
-Derek

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Nice!

  • dww committed a8c9af0 on 8.x-2.x 
    Issue #3091695 by dww, Sergiu Stici, ankushgautam76@gmail.com, heddn,...
dww’s picture

dww
we/he/they
commented
Title: Deprecated Code Report » Remove deprecated code and declare Drupal 9 compatibility
Status: Reviewed & tested by the community » Fixed

Did some further testing and confirmed all's well. Committed #7 and pushed to 8.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.