In the access callback we return either "FALSE", or webform_node_update_access($node). But if another module adds a custom access callback too, and this is executed before this callback, the results of that callback are ignored. We should include these results too.

CommentFileSizeAuthor
#4 access_callback-3091347-4.patch1.69 KBjoshahubbers
#2 access_callback-3091347-2.patch1.78 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new access_callback-3091347-2.patch1.78 KB

This patch returns FALSE, or the original callback combined with webform_node_update_access.

tvoesenek’s picture

tvoesenek commented
Status: Needs review » Needs work 
+++ b/dvg_webform_component_collections.module
@@ -346,10 +353,15 @@ function dvg_webform_component_collections_form_webform_admin_settings_alter(&$f
+  $retval = $original_access && user_access('custom webform permisssions editor plus');

The $retval variable is never used, looks like this line is some debug code, so it should be removed.
For the rest, the patch looks good.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new access_callback-3091347-4.patch1.69 KB

Good catch! Corrected patch.

joshahubbers’s picture

joshahubbers commented
Status: Needs work » Needs review
tvoesenek’s picture

tvoesenek commented
Status: Needs review » Reviewed & tested by the community

Looks good now ;-)

paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Changed the short array syntax to the long one since that is officially not yet supported for d7, and we've not yet officially dropped support for older php versions.

But essentially applied #4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.