php drupal-check.phar modules/contrib/view_mode_page/
 14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   src/Form/PatternEditForm.php                       
 ------ --------------------------------------------------- 
  294    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error
CommentFileSizeAuthor
#2 deprecated-3091325-2.patch633 bytessergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3091325-2.patch633 bytes

Here's the patch, please review.

bbombachini’s picture

bbombachini
Location London, ON
commented
Status: Needs review » Reviewed & tested by the community

Patch applies evenly and remove deprecated code warning.

bbombachini’s picture

bbombachini
Location London, ON
commented
Issue tags: +Drupal 9 compatibility
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Drupal 9 porting weekend

### modules/contrib/view_mode_page/view_mode_page.info.yml
Line: 0
Add core_version_requirement: ^8 || ^9 to view_mode_page.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

### modules/contrib/view_mode_page/src/PathProcessor/DynamicPathProcessor.php
Line: 68
Parameter $alias_manager of method Drupal\view_mode_page\PathProcessor\DynamicPathProcessor::__construct() has typehint with deprecated interface Drupal\Core\Path\AliasManagerInterface. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use Drupal\path_alias\AliasManagerInterface.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Related issues: +#3124738: Remove Deprecated interface

Added related issue.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Reviewed & tested by the community

Related issue #3124738 fixes report problems.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.