This task is there to implement the search form out of Figma to the PoC on GitHub. There is already a pull request on GitHub which outlines and implements this task but maybe there's something left.

The Figma design can be found here: https://www.figma.com/file/x5zBLbvoW1jsvyAOt4Gp9I/Olivero-Theme-Public?n...
The GitHub pull request can be found here: https://github.com/Lullabot/olivero-poc/pull/2

Tasks:

  1. Implement the search from (partly done)
  2. Check implemented search form in case of accessibility

Current implementation:
current implementation of search form

Screen out of Figma (expected result):
correct implementation of search form

CommentFileSizeAuthor
Bildschirmfoto 2019-10-28 um 16.13.01.png61.35 KBfhaeberle
Bildschirmfoto 2019-10-28 um 16.13.30.png51.44 KBfhaeberle

Comments

fhaeberle created an issue. See original summary.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Assigned: Unassigned » mherchel

Note I've been working on this at https://github.com/Lullabot/olivero-poc/pull/2.

I still have some cleanup to do, but overall it is working (see https://deploy-preview-2--olivero-poc.netlify.com/).

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Fixed

Marking this as fixed. I merged the PR

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented

Thanks! Nice one. 🎉

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Issue tags: -DrupalCon Amsterdam 2019 +Amsterdam2019

retagging

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.